From: "Christophe Jaillet" <christophe.jaillet@wanadoo.fr>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] drivers\char\synclink.c
Date: Fri, 25 Nov 2005 20:47:22 +0000 [thread overview]
Message-ID: <005701c5f201$6f7bf190$1e83c756@bureau> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 407 bytes --]
In file : \drivers\char\synclink.c
In function : line_info(char *buf, struct mgsl_struct *info)
The buffer *stat_buf* could be defined smaller.
It is used to build a string that can not be longer than "|RTS|CTS|DTR|DSR|CD|RI", that is to say 21 + 1 chars so :
char stat_buf[22];
instead of
char stat_buf[30];
would be enough and would save a few bytes on the stack.
CJ
[-- Attachment #1.2: Type: text/html, Size: 1395 bytes --]
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next reply other threads:[~2005-11-25 20:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-25 20:47 Christophe Jaillet [this message]
2005-11-25 21:34 ` [KJ] drivers\char\synclink.c Nish Aravamudan
2005-11-26 0:46 ` Matthew Wilcox
2005-11-26 0:58 ` Nish Aravamudan
2005-11-26 9:21 ` walter harms
2005-11-26 17:12 ` Nish Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='005701c5f201$6f7bf190$1e83c756@bureau' \
--to=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.