From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe() Date: Thu, 16 Apr 2015 13:07:41 -0500 Message-ID: <005801d07870$3b2dc530$b1894f90$@opengridcomputing.com> References: <552BB470.4090407@profitbricks.com> <552BB85D.7010400@profitbricks.com> <20150413203350.GA20611@obsidianresearch.com> <552CDA1F.4050609@profitbricks.com> <20150416164311.GB22946@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150416164311.GB22946-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Content-Language: en-us Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: 'Jason Gunthorpe' , 'Michael Wang' Cc: 'Roland Dreier' , 'Sean Hefty' , 'Hal Rosenstock' , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Tom Tucker' , 'Hoang-Nam Nguyen' , 'Christoph Raisch' , 'Mike Marciniszyn' , 'Eli Cohen' , 'Faisal Latif' , 'Jack Morgenstein' , 'Or Gerlitz' , 'Haggai Eran' , 'Ira Weiny' , 'Tom Talpey' , 'Doug Ledford' List-Id: linux-rdma@vger.kernel.org > -----Original Message----- > From: Jason Gunthorpe [mailto:jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org] > Sent: Thursday, April 16, 2015 11:43 AM > To: Michael Wang > Cc: Roland Dreier; Sean Hefty; Hal Rosenstock; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; Tom Tucker; Steve Wise; > Hoang-Nam Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira Weiny; > Tom Talpey; Doug Ledford > Subject: Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe() > > On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote: > > > > I would be very happy to see a patch that adds cap_ib_smi to the > > > current tree and states 'This patch is tested to have no change on the > > > binary compilation results' > > > > There are too much reform there (per-dev to per-port), I guess the binary > > will changed more or less anyway... > > I think this patch series is huge, and everytime someone new looks at > it small functional errors seem to pop up.. > > Doing something to reduce the review surface would be really helpful > here. Not changing the same line twice, using tools too perform these > transforms and then assert the patch is a NOP because .. tools. Some > other idea? > Don't try and change everything in one giant series. Just do some changes this cycle (keep it at < 8 or 10 patches), and do more later... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370AbbDPSHx (ORCPT ); Thu, 16 Apr 2015 14:07:53 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:56649 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932121AbbDPSHh (ORCPT ); Thu, 16 Apr 2015 14:07:37 -0400 From: "Steve Wise" To: "'Jason Gunthorpe'" , "'Michael Wang'" Cc: "'Roland Dreier'" , "'Sean Hefty'" , "'Hal Rosenstock'" , , , "'Tom Tucker'" , "'Hoang-Nam Nguyen'" , "'Christoph Raisch'" , "'Mike Marciniszyn'" , "'Eli Cohen'" , "'Faisal Latif'" , "'Jack Morgenstein'" , "'Or Gerlitz'" , "'Haggai Eran'" , "'Ira Weiny'" , "'Tom Talpey'" , "'Doug Ledford'" References: <552BB470.4090407@profitbricks.com> <552BB85D.7010400@profitbricks.com> <20150413203350.GA20611@obsidianresearch.com> <552CDA1F.4050609@profitbricks.com> <20150416164311.GB22946@obsidianresearch.com> In-Reply-To: <20150416164311.GB22946@obsidianresearch.com> Subject: RE: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe() Date: Thu, 16 Apr 2015 13:07:41 -0500 Message-ID: <005801d07870$3b2dc530$b1894f90$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQI/hhEY4CULeQ+RZjGdG1vocdrUEAGj6TUwAUtUh4oCCHus7wHebaT2nDsisXA= Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Jason Gunthorpe [mailto:jgunthorpe@obsidianresearch.com] > Sent: Thursday, April 16, 2015 11:43 AM > To: Michael Wang > Cc: Roland Dreier; Sean Hefty; Hal Rosenstock; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org; Tom Tucker; Steve Wise; > Hoang-Nam Nguyen; Christoph Raisch; Mike Marciniszyn; Eli Cohen; Faisal Latif; Jack Morgenstein; Or Gerlitz; Haggai Eran; Ira Weiny; > Tom Talpey; Doug Ledford > Subject: Re: [PATCH v3 27/28] IB/Verbs: Clean up rdma_ib_or_iboe() > > On Tue, Apr 14, 2015 at 11:13:03AM +0200, Michael Wang wrote: > > > > I would be very happy to see a patch that adds cap_ib_smi to the > > > current tree and states 'This patch is tested to have no change on the > > > binary compilation results' > > > > There are too much reform there (per-dev to per-port), I guess the binary > > will changed more or less anyway... > > I think this patch series is huge, and everytime someone new looks at > it small functional errors seem to pop up.. > > Doing something to reduce the review surface would be really helpful > here. Not changing the same line twice, using tools too perform these > transforms and then assert the patch is a NOP because .. tools. Some > other idea? > Don't try and change everything in one giant series. Just do some changes this cycle (keep it at < 8 or 10 patches), and do more later...