All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'Randy Dunlap'" <rdunlap@infradead.org>, <martin.petersen@oracle.com>
Cc: <avri.altman@wdc.com>, <linux-scsi@vger.kernel.org>,
	<sfr@canb.auug.org.au>
Subject: RE: [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning
Date: Wed, 5 Aug 2020 07:02:15 +0530	[thread overview]
Message-ID: <005b01d66ac8$429b8460$c7d28d20$@samsung.com> (raw)
In-Reply-To: <857eba45-475e-e2ea-86ba-e495794ae74c@infradead.org>

Hi Martin,

> On 7/21/20 10:20 AM, Alim Akhtar wrote:
> > With !CONFIG_OF and SCSI_UFS_EXYNOS selected, the below warning is
> > given:
> >
> > WARNING: unmet direct dependencies detected for PHY_SAMSUNG_UFS
> >   Depends on [n]: OF [=n] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> >   Selected by [y]:
> >   - SCSI_UFS_EXYNOS [=y] && SCSI_LOWLEVEL [=y] && SCSI [=y] &&
> > SCSI_UFSHCD_PLATFORM [=y] && (ARCH_EXYNOS || COMPILE_TEST [=y])
> >
> > Fix it by removing PHY_SAMSUNG_UFS dependency.
> >
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> 
> Looks good. Thanks.
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> 
I don’t see this patch in your tree, let me know if I need to -resend this.
Thanks!

> > ---
> >  drivers/scsi/ufs/Kconfig | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index
> > 46a4542f37eb..590768758fc6 100644
> > --- a/drivers/scsi/ufs/Kconfig
> > +++ b/drivers/scsi/ufs/Kconfig
> > @@ -164,7 +164,6 @@ config SCSI_UFS_BSG  config SCSI_UFS_EXYNOS
> >  	tristate "EXYNOS specific hooks to UFS controller platform driver"
> >  	depends on SCSI_UFSHCD_PLATFORM && (ARCH_EXYNOS ||
> COMPILE_TEST)
> > -	select PHY_SAMSUNG_UFS
> >  	help
> >  	  This selects the EXYNOS specific additions to UFSHCD platform driver.
> >  	  UFS host on EXYNOS includes HCI and UNIPRO layer, and associates
> > with
> >
> > base-commit: ab8be66e724ecf4bffb2895c9c91bbd44fa687c7
> >
> 
> 
> --
> ~Randy



  reply	other threads:[~2020-08-05  1:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200721174310epcas5p2a448e38c6e4d5e36e9f0417f5ddced6d@epcas5p2.samsung.com>
2020-07-21 17:20 ` [PATCH -next] scsi: ufs: Fix 'unmet direct dependencies' config warning Alim Akhtar
2020-07-21 17:57   ` Randy Dunlap
2020-08-05  1:32     ` Alim Akhtar [this message]
2020-08-05  1:37       ` Martin K. Petersen
2020-08-05  1:48         ` Alim Akhtar
2020-07-22  4:28   ` Martin K. Petersen
2020-09-15 20:16   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005b01d66ac8$429b8460$c7d28d20$@samsung.com' \
    --to=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.