From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C04C433E0 for ; Fri, 29 Jan 2021 03:13:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5CBEA64DE5 for ; Fri, 29 Jan 2021 03:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231803AbhA2DNW (ORCPT ); Thu, 28 Jan 2021 22:13:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229757AbhA2DNU (ORCPT ); Thu, 28 Jan 2021 22:13:20 -0500 Received: from mail-oo1-xc2e.google.com (mail-oo1-xc2e.google.com [IPv6:2607:f8b0:4864:20::c2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F006C061573 for ; Thu, 28 Jan 2021 19:12:40 -0800 (PST) Received: by mail-oo1-xc2e.google.com with SMTP id o5so1963572oop.12 for ; Thu, 28 Jan 2021 19:12:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Dctk8aov6+RstKFl2Jkajexwl/b2K3DwfJBBLKx9esk=; b=ZZTJi1viKP2NA2JNyeGZjQyGGwyyg2j/+ZRZOeQoLM262YePMl6Nr7cLVFqc/qCFXe 1oG3vHbfMEJYR+AosPTItZXntZDwFovKAhmp3L/Wgn1rG60TifAr3i2IiQaXUUPCe5ME k1v1IaXR9LV5Rwk6dkQ2YmGoS9c8YKuO+BRAr/jcbRLizFWGI8H/RNJBf5poMwtPYLmv 71+hGtDFN2XadKnc6tqAiHrdsEzvXbnLi4YYfbNTLN1Up4MG412nWFuMFG4UiD+bO0zz 2JkzDhuCjT7SKGz0prIsQgmpv/+Lh/kI7Vur83tYQobzxncYBDnAfCE5n9v3tuqPEPLz f1jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Dctk8aov6+RstKFl2Jkajexwl/b2K3DwfJBBLKx9esk=; b=d8WpoXm9te0BOTx/r28AP4Vcr9/iYvao2B+AZWqZp4irV+KqOKvQ5tXYtlA+B6CzHL mawQEethxG5dbqKcQHiwn0DeRtLyjt5u7MkBl3xg3Sg8WB/0Ut/GVM16jmCHnFcXSybJ ob0oRR2ulf3Jce5HaczPcnV9K+bKEtGGwl9tim706C+BHOvXqzuxP1K+DUxtIEpN1jiH 01cuFpAZ5/IlQwLPF9nCAOzmtTzUS9Dj0LzjkbXcwN3+kthNxHvZECPyb7HG40CtJKXC b3Vhbntqyt1bDTJXCjmfdWUWF7Oe5AmMXkFM1y9n4KiBK2qtlm1P8Vjn+1SAzuHK653K WKpQ== X-Gm-Message-State: AOAM531/vuSzEXXReQnB4bLUsYD3/nizFZ9NOQ5PpzGgqZIdvgQTF3xR QESEDqiqTTI9NqfRWh5Z3NA= X-Google-Smtp-Source: ABdhPJyjMOKhP72sv4QOH8ikFGFzsWcdjRuvCOHKpBnev6iIDRD4Y/RTgHk7xVf5Ia6Bybb2B+AyxQ== X-Received: by 2002:a4a:4302:: with SMTP id k2mr1814746ooj.50.1611889959606; Thu, 28 Jan 2021 19:12:39 -0800 (PST) Received: from Davids-MacBook-Pro.local ([8.48.134.50]) by smtp.googlemail.com with ESMTPSA id y17sm1814695oie.7.2021.01.28.19.12.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 19:12:39 -0800 (PST) Subject: Re: [PATCH net-next 05/12] nexthop: Use enum to encode notification type To: Petr Machata , netdev@vger.kernel.org Cc: David Ahern , "David S. Miller" , Jakub Kicinski , Ido Schimmel References: <687076047917503b42f35ef9739208b9aaa5bb15.1611836479.git.petrm@nvidia.com> From: David Ahern Message-ID: <005e0faf-7021-7ec7-e6b3-33892db120c3@gmail.com> Date: Thu, 28 Jan 2021 20:12:37 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <687076047917503b42f35ef9739208b9aaa5bb15.1611836479.git.petrm@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/28/21 5:49 AM, Petr Machata wrote: > From: Ido Schimmel > > Currently there are only two types of in-kernel nexthop notification. > The two are distinguished by the 'is_grp' boolean field in 'struct > nh_notifier_info'. > > As more notification types are introduced for more next-hop group types, a > boolean is not an easily extensible interface. Instead, convert it to an > enum. > > Signed-off-by: Ido Schimmel > Reviewed-by: Petr Machata > Signed-off-by: Petr Machata > --- > .../ethernet/mellanox/mlxsw/spectrum_router.c | 54 ++++++++++++++----- > drivers/net/netdevsim/fib.c | 23 ++++---- > include/net/nexthop.h | 7 ++- > net/ipv4/nexthop.c | 14 ++--- > 4 files changed, 69 insertions(+), 29 deletions(-) > Reviewed-by: David Ahern