From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Masayuki Ohtake" Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 Date: Mon, 13 Sep 2010 21:07:44 +0900 Message-ID: <005f01cb533e$5c21d530$66f8800a@maildom.okisemi.com> References: <4C61EDE5.4030505@dsn.okisemi.com> <4C629FE5.6000204@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: andrew.chih.howe.khor-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, qi.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, yong.y.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org, Morinaga , meego-dev-WXzIur8shnEAvxtiuMwx3w@public.gmane.org, arjan-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, Wolfgang Grandegger To: "Marc Kleine-Budde" Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org Errors-To: socketcan-core-bounces-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org List-Id: netdev.vger.kernel.org ----- Original Message ----- From: "Marc Kleine-Budde" To: "Masayuki Ohtak" Cc: ; "Wolfgang Grandegger" ; ; ; ; ; ; ; Sent: Wednesday, August 11, 2010 10:04 PM Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_CAN driver to 2.6.35 Hi Marc, > - Try to send patches directly with git send-email In our network environment, we can't use send-email. > - don't use global variables I have modified so that our patch doesn't use global variable except module parameter. > - don't use that "int handle", e.g.: I have deleted. > - get rid of the intermediate struct pch_can_msg: > Your data path is: > struct can_frame -> struct pch_can_msg -> registers > write from struct can_frame into registers directly Since Topcliff CAN HW register assign is different from struct can_frame, I think intermediate structure is necessary. > - what's the purpose of "p_can_os->can_callback", call the function > directly from the interrupt handler I have deleted > - implement NAPI Since Topcliff CAN HW register has only single rx buffer, I think NAPI is unnecessary. > - get rid of "1 << BIT_SHIFT_SIX" and friend, > use "1 << 6" or "BIT(6)" if you like defines I have modified. > - use defines to set bits in struct can_frame can_id I have modified. I will resubmit modified our CAN patch soon. Thanks, Ohtake(OKISemi)