From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1SX5Nh-00067V-Ht
	for qemu-devel@nongnu.org; Wed, 23 May 2012 02:49:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1SX5Nf-0007Kh-CF
	for qemu-devel@nongnu.org; Wed, 23 May 2012 02:49:13 -0400
Received: from mail.ispras.ru ([83.149.199.43]:33215)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Pavel.Dovgaluk@ispras.ru>) id 1SX5Nf-0007HS-4y
	for qemu-devel@nongnu.org; Wed, 23 May 2012 02:49:11 -0400
From: "Pavel Dovgaluk" <Pavel.Dovgaluk@ispras.ru>
References: <4fb35a7e.2458b40a.3ed6.649cSMTPIN_ADDED@mx.google.com>
	<CAOZVR5a8ONxE+XZSJXON3hConUEJNryJCta8cbwcPKbjb30-Zw@mail.gmail.com>
	<001001cd334c$e8d95260$ba8bf720$@Dovgaluk@ispras.ru>
	<4FBB5396.2010001@redhat.com> <4FBB5B80.20409@redhat.com>
In-Reply-To: <4FBB5B80.20409@redhat.com>
Date: Wed, 23 May 2012 10:48:57 +0400
Message-ID: <005f01cd38b0$20d8a180$6289e480$@Dovgaluk@ispras.ru>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Qemu-devel] [PATCH] Prevent disk data loss when closing qemu
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: 'Paolo Bonzini' <pbonzini@redhat.com>, 'Kevin Wolf' <kwolf@redhat.com>
Cc: 'dunrong huang' <riegamaths@gmail.com>, 'qemu-devel' <qemu-devel@nongnu.org>, 'Anthony Liguori' <anthony@codemonkey.ws>

> From: Paolo Bonzini [mailto:paolo.bonzini@gmail.com] On Behalf Of Paolo Bonzini
> Il 22/05/2012 10:51, Kevin Wolf ha scritto:
> > Am 16.05.2012 12:16, schrieb Pavel Dovgaluk:
> >> I use qemu under Windows and it has two windows when executes - console and SDL ones.
> >> When I close SDL window main loop function terminates correctly, and when I close
> >> console window to terminate qemu then the code after main loop is not executed.
> >
> > Is there no way to catch this case and use the regular shutdown
> > mechanism there as well?
> >
> > I'm not against your patch and it's probably 1.1 material, but there may
> > be more shutdown logic that we're missing if you close the console window.
> 
> Looks like qemu_ctrl_handler (in os-win32.c) needs to do something like
> termsig_handler (in os-posix.c) instead of a plain exit.

  I tried to call qemu_system_shutdown_request() instead of exit() there, but Windows kills qemu
before it finishes cleanup work.

Pavel Dovgaluk