All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namjae Jeon <namjae.jeon@samsung.com>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>
Subject: RE: [PATCH 5/5] ext4: Fix extent merging in ext4_ext_shift_path_extents()
Date: Thu, 17 Apr 2014 14:55:41 +0900	[thread overview]
Message-ID: <005f01cf5a01$aa187370$fe495a50$@samsung.com> (raw)
In-Reply-To: <004501cf5a00$18bec8d0$4a3c5a70$@samsung.com>

> There is a bug in ext4_ext_shift_path_extents() where if we actually
> manage to merge a extent we would skip shifting the next extent. This
> will result in in one extent in the extent tree not being properly
> shifted.
> 
> This is causing failure in various xfstests tests using fsx or fsstress
> with collapse range support. It will also cause file system corruption
> which looks something like:
> 
>  e2fsck 1.42.9 (4-Feb-2014)
>  Pass 1: Checking inodes, blocks, and sizes
>  Inode 20 has out of order extents
>         (invalid logical block 3, physical block 492938, len 2)
>  Clear? yes
>  ...
> 
> when running e2fsck.
> 
> It's also very easily reproducible just by running fsx without any
> parameters. I can usually hit the problem within a minute.
> 
> Fix it by increasing ex_start only if we're not merging the extent.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
You can add : Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com>

Thanks!





       reply	other threads:[~2014-04-17  5:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <004501cf5a00$18bec8d0$4a3c5a70$@samsung.com>
2014-04-17  5:55 ` Namjae Jeon [this message]
2014-04-18 14:55   ` [PATCH 5/5] ext4: Fix extent merging in ext4_ext_shift_path_extents() Theodore Ts'o
2014-04-16 18:32 [PATCH 1/5] ext4: Use filemap_write_and_wait_range() correctly in collapse range Lukas Czerner
2014-04-16 18:33 ` [PATCH 5/5] ext4: Fix extent merging in ext4_ext_shift_path_extents() Lukas Czerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='005f01cf5a01$aa187370$fe495a50$@samsung.com' \
    --to=namjae.jeon@samsung.com \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.