From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03469C433E0 for ; Tue, 9 Jun 2020 09:09:12 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C40FB207C3 for ; Tue, 9 Jun 2020 09:09:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Szl5DFLC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C40FB207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiaFh-0007bS-6h; Tue, 09 Jun 2020 09:09:01 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiaFg-0007bN-FP for xen-devel@lists.xenproject.org; Tue, 09 Jun 2020 09:09:00 +0000 X-Inumbo-ID: dad5e14c-aa30-11ea-bb8b-bc764e2007e4 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id dad5e14c-aa30-11ea-bb8b-bc764e2007e4; Tue, 09 Jun 2020 09:08:59 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id c3so20360682wru.12 for ; Tue, 09 Jun 2020 02:08:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=e87qbX8taTu/TmxWOZZTUTjhubAMWOgGXPqyXIjZre0=; b=Szl5DFLCV0wa7N1KmocMXcuVbyDZ96YoyMV4oGP4FbmyxZVP72SwbgIxv+pG2Tq9F8 TV+49/UIjbQtYpON2Qcns8xASS3Zwt8rVUzgoYfdl372j3tFusESBVfn5VqxI5Pdvw7I o4O1myzM23i+QCS3I0nqWxGnP2nCW7HSZ2nPIwKfyvKFDdjxHX+pWiegGJDrM3VvJps8 lbmQlOr5QH+v8iXFBKRX8KKKA6t3NoGL87fPeKbqf15e1IW7/j4yhcLgSyeUyRRpczC9 kQHKRTbC3WvteuZ8MQGAIaKTVFvB+9xY9nF5/VLlioLgkMZAyUXkAsbT8TTlJ1PBbiDm Z/hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=e87qbX8taTu/TmxWOZZTUTjhubAMWOgGXPqyXIjZre0=; b=aL0R7TwrnvpTF9x6TEKVRKlWACSemBVELBQgqCok7EmD5JvZpBiML8N93L/V+d16KH ahqT40n8BtFiXw8oXIGuEi91cghhpnztJnxvyRojRxXu1iE73wqu5msTU6D/T36HMz+W htukbRW6rPXGM7wBmlxKxO658gwYyaypiX07HhLdRjan8k/606eMOGx4/RlNWllJZtUv GMymaz3E1Doa5Vmv2RffzhOo2cUj06b13MHFiN4I/7MBLQgbaytRTr7r7jQz5I/XHMFY 4SNVKnyptRs9Zs+5W2ydgO58HvaeWx9orhhQZtvcQcMX0XTnyR28ZnKXsuND9UgWsPA0 w9mQ== X-Gm-Message-State: AOAM533I+ciOdqB/IS6hVZkldT4sUOCGAIBF7evUpS5wWK2BozIMOtE2 03+1T5PMb82fP+SB64EkKdBDQjM/+co= X-Google-Smtp-Source: ABdhPJzE1wIbGcSCkqzYyWl32XvYIdYYc4BXaKKH7g+kVPVNfc7YCwPhwBFFewvnfD4n0cLIm4977w== X-Received: by 2002:a05:6000:10cf:: with SMTP id b15mr3220723wrx.214.1591693739219; Tue, 09 Jun 2020 02:08:59 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.187]) by smtp.gmail.com with ESMTPSA id e15sm2351474wme.9.2020.06.09.02.08.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jun 2020 02:08:58 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: =?utf-8?Q?'J=C3=BCrgen_Gro=C3=9F'?= , "'Olaf Hering'" , "'Paul Durrant'" References: <20200608203849.18341-1-olaf@aepfle.de> <005001d63e3b$c85059f0$58f10dd0$@xen.org> <20200609110016.16a52277.olaf@aepfle.de> <005f01d63e3c$fcf84fe0$f6e8efa0$@xen.org> In-Reply-To: Subject: RE: [PATCH v1] kdd: remove zero-length arrays Date: Tue, 9 Jun 2020 10:08:57 +0100 Message-ID: <006301d63e3d$9c141fa0$d43c5ee0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIqIZk/Qusa7Qsu5bkjM27jAUAPHgHVoA+LAZtbwz4ChcRm7gE/+bE7p+6BznA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: xen-devel@lists.xenproject.org, 'Ian Jackson' , 'Wei Liu' , 'Tim Deegan' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: J=C3=BCrgen Gro=C3=9F > Sent: 09 June 2020 10:06 > To: paul@xen.org; 'Olaf Hering' ; 'Paul Durrant' = > Cc: xen-devel@lists.xenproject.org; 'Ian Jackson' = ; 'Wei Liu' ; > 'Tim Deegan' > Subject: Re: [PATCH v1] kdd: remove zero-length arrays >=20 > On 09.06.20 11:04, Paul Durrant wrote: > >> -----Original Message----- > >> From: Olaf Hering > >> Sent: 09 June 2020 10:00 > >> To: Paul Durrant > >> Cc: paul@xen.org; xen-devel@lists.xenproject.org; 'Ian Jackson' = ; 'Tim > >> Deegan' ; 'Wei Liu' > >> Subject: Re: [PATCH v1] kdd: remove zero-length arrays > >> > >> Am Tue, 9 Jun 2020 09:55:52 +0100 > >> schrieb Paul Durrant : > >> > >>> Is it not sufficient to just change the declaration of payload in = kdd_pkt from [0] to []? > >> > >> AFAIR this lead to compile errors. > >> > > > > OOI which compiler (might be worth mentioning in the commit comment = too, for reference)? I'm not > seeing a problem. >=20 > We don't use array[] in public headers, but AFAIK using them = internally > is fine. >=20 Yeah, we have XEN_FLEX_ARRAY_DIM for public headers. Paul >=20 > Juergen