From: "Randall S. Becker" <rsbecker@nexbridge.com>
To: "'Jonathan Nieder'" <jrnieder@gmail.com>
Cc: 'demerphq' <demerphq@gmail.com>, "'Jeff King'" <peff@peff.net>,
"'Eric Wong'" <e@80x24.org>, 'Git' <git@vger.kernel.org>,
"'Joachim Schmitz'" <jojo@schmitz-digital.de>,
"'Ævar Arnfjörð Bjarmason'" <avarab@gmail.com>
Subject: RE: [Problem] test_must_fail makes possibly questionable assumptions about exit_code.
Date: Wed, 28 Feb 2018 15:04:01 -0500 [thread overview]
Message-ID: <006901d3b0cf$4a3f7d30$debe7790$@nexbridge.com> (raw)
In-Reply-To: <20180228185152.GE251290@aiede.svl.corp.google.com>
On February 28, 2018 1:52 PM, Jonathan Nieder wrote:
> Randall S. Becker wrote:
> > On February 28, 2018 12:44 PM, Jonathan Nieder wrote:
> >> Randall S. Becker wrote:
>
> >>> The problem is actually in git code in its test suite that uses perl
> >>> inline, not in my test code itself.
> [...]
> >> Can you elaborate with an example? My understanding was that
> >> test_must_fail is only for running git.
> [...]
> > Have a look at a recent t1404 as a sample. Line 615 is the one causing
> > the platform grief, because it triggers a 'die'. However, the
> > particular test case #54, had no difference on platform with
> > test_must_fail or !, which has the same underlying EBADF completion
after
> digging and digging.
>
> Sorry to be dense: what I see on that line is
>
> test_must_fail git update-ref -d $prefix/foo >out 2>err &&
My bad, I think. I'm going to go looking through my notes and get back on
which line in the test was the issue. I assumed from your response that it
might have been the test_must_fail, which is throughout the git test suite.
Obviously it isn't the line failing in this case. Stay tuned.
next prev parent reply other threads:[~2018-02-28 20:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:50 [Problem] test_must_fail makes possibly questionable assumptions about exit_code Randall S. Becker
2018-02-28 0:16 ` Jonathan Nieder
2018-02-28 4:07 ` Eric Wong
2018-02-28 5:00 ` Jeff King
2018-02-28 7:42 ` Eric Wong
2018-02-28 7:49 ` Jeff King
2018-02-28 14:55 ` Randall S. Becker
2018-02-28 16:51 ` demerphq
2018-03-01 7:36 ` Jeff King
2018-03-01 8:16 ` demerphq
2018-03-01 14:28 ` Randall S. Becker
2018-03-01 15:08 ` Jeff King
2018-03-01 15:30 ` demerphq
2018-02-28 16:22 ` Junio C Hamano
2018-02-28 16:46 ` demerphq
2018-02-28 17:10 ` Randall S. Becker
2018-02-28 17:19 ` demerphq
2018-02-28 17:20 ` demerphq
2018-02-28 17:32 ` Randall S. Becker
2018-02-28 17:44 ` Jonathan Nieder
2018-02-28 18:21 ` Randall S. Becker
2018-02-28 18:51 ` Jonathan Nieder
2018-02-28 20:04 ` Randall S. Becker [this message]
2018-02-28 22:02 ` Randall S. Becker
2018-02-28 23:16 ` Jonathan Nieder
2018-03-01 7:34 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006901d3b0cf$4a3f7d30$debe7790$@nexbridge.com' \
--to=rsbecker@nexbridge.com \
--cc=avarab@gmail.com \
--cc=demerphq@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=jojo@schmitz-digital.de \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.