From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4805C433DF for ; Thu, 18 Jun 2020 16:02:05 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D61D2075E for ; Thu, 18 Jun 2020 16:02:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qQOHKOpI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D61D2075E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlwz9-0003q3-OZ; Thu, 18 Jun 2020 16:01:51 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jlwz8-0003pj-7h for xen-devel@lists.xenproject.org; Thu, 18 Jun 2020 16:01:50 +0000 X-Inumbo-ID: 0479602a-b17d-11ea-bb8b-bc764e2007e4 Received: from mail-wr1-x436.google.com (unknown [2a00:1450:4864:20::436]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 0479602a-b17d-11ea-bb8b-bc764e2007e4; Thu, 18 Jun 2020 16:01:49 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id q2so4186659wrv.8 for ; Thu, 18 Jun 2020 09:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=fYe3LoFUceqMJwwcKHTwyFS5p3TKF8kVHKKkDzRMsFU=; b=qQOHKOpI/WBha+qg4XrmxITIaC3ckHMZUGqFdziGhWJ8vpEaaBuhDtwvE0ffySqV7u 9R4o99h16dCHghxphnjoSb2Ya7nfnzhTrjSlLjjJRxj+mcn9vNcyPaBlP6BdyhYpVM4a aSV0Ds+wQfR031awI9mGOIVQyrBneZB1+ZBBzdktmSJcTD/KixTPVPjMK+chf7iGhcsj OXuE8KtBOpfFOI7dpRvJYtCQ3J7Xl98sbnBxe5R8cTTd46mh/UIExUtolqXJ+QCPC3QX LZWm5Yx7ONFlXbYAwWhsD0KfWsbbYML63KEqYFaWC0+OJgzLBpggRj7MikxcXn4qBCxp ZVuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=fYe3LoFUceqMJwwcKHTwyFS5p3TKF8kVHKKkDzRMsFU=; b=sdmLP8DkDWGRcojAdW8GegTD11evyoLIPMmHDIiSOf3YMX0nf0NMBNLarPbiKwaQ5K Coi2taiabDf1aDyLaDGLGED62gQ4bAwpmYfSGYWQZIu+q7K/sISi/06GpD9iLN8apLla IIQzD/ugR9b2hDCEaGBj/Z9x9oIaboajwPZj6tBkqrA08PpZ9nyrRkKSDBj0Dpi0lk29 gMLgDprZZElVhzr4g+l3/LKAIhrMxTP+oAbc7HJgxK1Q6fkqTMIST+ngwXjb5V5r50dT XoJjuZuqYFjjcGwRYnkkH1bQEf3SHruEbyW38OAv7CymGy4fpX17hXkRV8o3Hy/wZO6Y xlAA== X-Gm-Message-State: AOAM530RQoidU2qtqwCgOHYL+p6fQEmcSl9XDZ8Wr/IoPf/2vraGW7nO ifcAX6DqqFQVUikOPHd6VJw= X-Google-Smtp-Source: ABdhPJzk8LQUJOSuRcE11JXMS40YUYyeRp83+bAz9LIB3hos/f0ydGeNJrLtcNFXjcN2Ln4mbzbmbA== X-Received: by 2002:a5d:66c3:: with SMTP id k3mr5228904wrw.401.1592496108917; Thu, 18 Jun 2020 09:01:48 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.187]) by smtp.gmail.com with ESMTPSA id d11sm4223536wrm.64.2020.06.18.09.01.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jun 2020 09:01:48 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Ian Jackson'" , "'Paul Durrant'" References: <20200617060841.7241-1-olaf@aepfle.de> <20200617134025.2tdrjxslnh66dmng@function> <24299.36521.246994.731819@mariner.uk.xensource.com> In-Reply-To: <24299.36521.246994.731819@mariner.uk.xensource.com> Subject: RE: [XEN PATCH for-4.14 v1] stubdom/vtpm: add extern to function declarations Date: Thu, 18 Jun 2020 17:01:46 +0100 Message-ID: <006901d64589$c593c440$50bb4cc0$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQIv4nHnfBuTNWH2eRSm761nFo0E0wJ3IkteAgwDO1EB4kHQg6f4IwYw X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Samuel Thibault' , 'Olaf Hering' , 'xen-devel' , 'Wei Liu' , 'Jason Andryuk' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Ian Jackson > Sent: 18 June 2020 16:56 > To: Paul Durrant > Cc: Samuel Thibault ; Jason Andryuk ; Olaf Hering > ; xen-devel ; Wei Liu > Subject: Re: [XEN PATCH for-4.14 v1] stubdom/vtpm: add extern to function declarations > > Samuel Thibault writes ("Re: [PATCH v1] stubdom/vtpm: add extern to function declarations"): > > Jason Andryuk, le mer. 17 juin 2020 09:35:52 -0400, a ecrit: > > > On Wed, Jun 17, 2020 at 2:10 AM Olaf Hering wrote: > > > > > > > > Code compiled with gcc10 will not link properly due to multiple definition of the same function. > > > > > > > > Signed-off-by: Olaf Hering > > > > > > Reviewed-by: Jason Andryuk > > > > Acked-by: Samuel Thibault > > Reviewed-by: Ian Jackson > > Thanks. I have confirmed that these symbols look to be defined (in > tpm/tpm_emulator_extern.c). So the patch is correct. > > I think this is 4.14 material. Paul ? Agreed. Release-acked-by: Paul Durrant > > We should also consider it for backports. How far back do we need > to go ? > > Ian.