All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Cc: <Mori.Takahiro@ab.MitsubishiElectric.co.jp>,
	<Motai.Hirotaka@aj.MitsubishiElectric.co.jp>,
	"'Sungjong Seo'" <sj1557.seo@samsung.com>,
	<linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"'Matthew Wilcox'" <willy@infradead.org>
Subject: RE: [PATCH v2] exfat: replace 'time_ms' with 'time_10ms'
Date: Thu, 16 Apr 2020 15:47:24 +0900	[thread overview]
Message-ID: <006a01d613ba$e2e19e10$a8a4da30$@samsung.com> (raw)
In-Reply-To: <TY1PR01MB157894A971A781BE900C5A7590DD0@TY1PR01MB1578.jpnprd01.prod.outlook.com>

> > Please leave at least 24 hours between sending new versions so that
> > you can collect all feedback relating to your change, and we don't see
> > discussion fragment between different threads.
> 
> Thanks for good advice!
> 
> > > +		ts->tv_sec += (time_10ms * 10) / 1000;
> > > +		ts->tv_nsec = (time_10ms * 10) % 1000 * NSEC_PER_MSEC;
> >
> > I find this more confusing than the original.
> 
> The parentheses were intended to group conversions into milliseconds, but
> were not necessary from an "operator precedence" perspective.
> 
> 
> >
> > 		ts->tv_sec += time_10ms / 100;
> > 		ts->tv_nsec = (time_10ms % 100) * 10 * NSEC_PER_MSEC;
> >
> > is easier to understand for me, not least because I don't need to worry
> > about the operator precedence between % and *.
> 
> If I use '100' for the divisor of '10ms', I find it difficult to
> understand
> the meaning of the operation.
> 
> When using '100' for the divisor, I think cs (centi-sec) is easier to
> understand than 10ms.
> Which do you prefer, time_10ms or time_cs?
Can you resend the patch again after changing to time_cs ?

> 
> 
> BR
> ---
> Kohada Tetsuhiro <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>


  reply	other threads:[~2020-04-16  6:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  7:46 [PATCH v2] exfat: replace 'time_ms' with 'time_10ms' Tetsuhiro Kohada
2020-04-08 11:21 ` Matthew Wilcox
2020-04-13  9:41   ` Kohada.Tetsuhiro
2020-04-16  6:47     ` Namjae Jeon [this message]
2020-04-16  7:45       ` Kohada.Tetsuhiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006a01d613ba$e2e19e10$a8a4da30$@samsung.com' \
    --to=namjae.jeon@samsung.com \
    --cc=Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp \
    --cc=Mori.Takahiro@ab.MitsubishiElectric.co.jp \
    --cc=Motai.Hirotaka@aj.MitsubishiElectric.co.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sj1557.seo@samsung.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.