From: Stefan Schmidt <s.schmidt@samsung.com>
To: 'Alexander Aring' <alex.aring@gmail.com>, linux-wpan@vger.kernel.org
Subject: Re: [PATCH wpan-tools 1/2] treewide: shorten commands
Date: Tue, 20 Jan 2015 11:05:26 +0000 [thread overview]
Message-ID: <006b01d034a0$ff2e9900$fd8bcb00$@samsung.com> (raw)
In-Reply-To: <1421750140-24760-1-git-send-email-alex.aring@gmail.com>
Hello.
On 20/01/15 11:35, Alexander Aring wrote:
> This patch shorten all commands. I had the idea to make a similarity
> from PIB/MIB values according the 802.15.4 names convention but this is
> bad for fast shell hacking. Mainly I remove the underscore and some
> additional information which are not necessary like "_addr" in
> "short_addr" and "extended_addr" and such things.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> src/info.c | 10 +++++-----
> src/interface.c | 20 ++++++++++----------
> src/mac.c | 10 +++++-----
> src/phy.c | 6 +++---
> 4 files changed, 23 insertions(+), 23 deletions(-)
Hmm, it feels like you are going overboard with shorting things here.
Why is the reason behind it? Just less typing? Shell auto completion
would handle this. :)
I mean it is up to you but with this you might break scripts that are
already out there and I think the current commands are quite fine.
Cutting out the underscores makes some of these hard to read imho.
regards
Stefan Schmidt
next prev parent reply other threads:[~2015-01-20 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 10:35 [PATCH wpan-tools 1/2] treewide: shorten commands Alexander Aring
2015-01-20 10:35 ` [PATCH wpan-tools 2/2] interface: remove twice phy information Alexander Aring
2015-01-20 11:05 ` Stefan Schmidt [this message]
2015-01-20 11:32 ` [PATCH wpan-tools 1/2] treewide: shorten commands Alexander Aring
2015-01-20 11:47 ` Alexander Aring
2015-01-20 14:43 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='006b01d034a0$ff2e9900$fd8bcb00$@samsung.com' \
--to=s.schmidt@samsung.com \
--cc=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.