Re: [dpdk-dev] [PATCH v4 1/6] net/ngbe: add build and doc infrastructure

["Jiawen Wu" <jiawenwu@trustnetic.com>]

On April 9, 2021 10:37 PM, Ferruh Yigit wrote:
> On 4/6/2021 10:30 AM, Jiawen Wu wrote:
> > Adding bare minimum PMD library and doc build infrastructure and claim
> > the maintainership for ngbe PMD.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> 
> <...>
> 
> > diff --git a/doc/guides/nics/ngbe.rst b/doc/guides/nics/ngbe.rst new
> > file mode 100644 index 000000000..007d8e80e
> > --- /dev/null
> > +++ b/doc/guides/nics/ngbe.rst
> > @@ -0,0 +1,28 @@
> > +..  SPDX-License-Identifier: BSD-3-Clause
> > +    Copyright(c) 2018-2020.
> 
> You may want to add who is the copyright owner, like "Intel Corporation" part
> in
> Copyright(c) 2017-2019 Intel Corporation
> 
> I recognized same is missing in txgbe too, can you fix that too please?
> 

I'm thinking about it...

> > +
> > +NGBE Poll Mode Driver
> > +======================
> > +
> > +The NGBE PMD (librte_pmd_ngbe) provides poll mode driver support for
> > +Wangxun 1 Gigabit Ethernet NICs.
> > +
> > +Prerequisites
> > +-------------
> > +
> > +- Learning about Wangxun 10 Gigabit Ethernet NICs using
> 
> "10 Gigabit" or "1 Gigabit"?
> 

It's a clerical error.

> > +  `<https://www.net-swift.com/a/386.html>`_.
> > +
> 
> What is the relation between netswift/WebEx/Wangxun ?

Wangxun is Chinese spell of our company name, trustnetic and net-swift are domain names.
WebEx, as far as I know, its Chinese translation is the same as Wangxun, but it has nothing relation between us.