From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D383FC25B75 for ; Wed, 15 May 2024 07:10:00 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.721941.1125655 (Exim 4.92) (envelope-from ) id 1s78lc-0007M3-Vd; Wed, 15 May 2024 07:09:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 721941.1125655; Wed, 15 May 2024 07:09:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1s78lc-0007Lw-Sr; Wed, 15 May 2024 07:09:36 +0000 Received: by outflank-mailman (input) for mailman id 721941; Wed, 15 May 2024 07:09:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1s78lb-0007Ig-EV for xen-devel@lists.xenproject.org; Wed, 15 May 2024 07:09:35 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1460df76-128a-11ef-b4bb-af5377834399; Wed, 15 May 2024 09:09:33 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id 5FF4A4EE0738; Wed, 15 May 2024 09:09:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1460df76-128a-11ef-b4bb-af5377834399 MIME-Version: 1.0 Date: Wed, 15 May 2024 09:09:32 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Simone Ballarin , Doug Goldstein , Andrew Cooper , George Dunlap , Jan Beulich Subject: Re: [XEN PATCH 03/10] automation/eclair_analysis: deviate macro count_args_ for MISRA Rule 20.7 In-Reply-To: References: <7de407c218f0911e28b7c3f609a55636165166a8.1713885065.git.nicola.vetrini@bugseng.com> <5b675fcdf688723bc6d4ea260d10004e@bugseng.com> Message-ID: <006e9d571de6383679ab7fdb84dfcdd7@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2024-05-01 21:54, Stefano Stabellini wrote: > On Mon, 29 Apr 2024, Nicola Vetrini wrote: >> On 2024-04-25 02:28, Stefano Stabellini wrote: >> > On Tue, 23 Apr 2024, Nicola Vetrini wrote: >> > > The count_args_ macro violates Rule 20.7, but it can't be made >> > > compliant with Rule 20.7 without breaking its functionality. Since >> > > it's very unlikely for this macro to be misused, it is deviated. >> > >> > That is OK but can't we use the SAF- framework to do it, given that it >> > is just one macro? >> > >> > If not, this is also OK. >> > >> > >> >> It would be more fragile, for no substantial gain > > OK > > Reviewed-by: Stefano Stabellini Hi, I think this patch slipped through the cracks. I see it only has Stefano's R-by, so perhaps it needs a further ack? Thanks, -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)