From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33922) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJkBa-0001IH-OW for qemu-devel@nongnu.org; Mon, 27 Jul 2015 11:19:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZJkBV-0002vg-Mp for qemu-devel@nongnu.org; Mon, 27 Jul 2015 11:19:26 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:62622) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZJkBV-0002uW-HV for qemu-devel@nongnu.org; Mon, 27 Jul 2015 11:19:21 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NS500DDSJW66F30@mailout4.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 27 Jul 2015 16:19:18 +0100 (BST) From: Pavel Fedin References: <507c11db2c97eef33de0e4f7168076d5c39f0867.1436866326.git.p.fedin@samsung.com> <87r3ntzra9.fsf@blackfin.pond.sub.org> <003201d0c879$8fced800$af6c8800$@samsung.com> <55B646CD.8010808@suse.de> <55B64900.6020008@redhat.com> In-reply-to: <55B64900.6020008@redhat.com> Date: Mon, 27 Jul 2015 18:19:17 +0300 Message-id: <007201d0c87f$9b3e5660$d1bb0320$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-transfer-encoding: quoted-printable Content-language: ru Subject: Re: [Qemu-devel] [PATCH v4 2/2] QOM: object_property_add() performance improvement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Paolo Bonzini' , =?utf-8?Q?'Andreas_F=C3=A4rber'?= , 'Markus Armbruster' Cc: qemu-devel@nongnu.org Hello! > I'm just asking myself whether this is really necessary. Is the > automagic [*] really needed in this case? =20 In this particular case, perhaps, not. However, this automagic is used = not only with GPIOs. It is used also with memory regions, as well as = with some other places. Also, i thought that there could be some hard to = notice problems, when, for example, we first add = unnamed-gpio-in[0...1023], then add another 1024 pins, where count again = goes from 0 to 1023. And we would get collision and failure, unless we = know, that we already have 1024 objects with this name. So, just for = better safety, i decided to fix the mechanism itself instead of changing = use cases. Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia