All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] TI DaVinci: Driver for the davinci SPI controller
Date: Thu, 24 Dec 2009 08:22:59 +0530	[thread overview]
Message-ID: <007301ca8444$33d9ba30$9b8d2e90$@raj@ti.com> (raw)
In-Reply-To: <200912232034.19889.vapier@gentoo.org>

Hi,

On Thu, Dec 24, 2009 at 07:04:18, Mike Frysinger wrote:
> On Wednesday 23 December 2009 02:44:36 Sudhakar Rajashekhara wrote:
> > --- a/drivers/spi/Makefile
> > +++ b/drivers/spi/Makefile
> > @@ -34,6 +34,7 @@ COBJS-$(CONFIG_MPC52XX_SPI) += mpc52xx_spi.o
> >  COBJS-$(CONFIG_MPC8XXX_SPI) += mpc8xxx_spi.o
> >  COBJS-$(CONFIG_MXC_SPI) += mxc_spi.o
> >  COBJS-$(CONFIG_SOFT_SPI) += soft_spi.o
> > +COBJS-$(CONFIG_DAVINCI_SPI) += davinci_spi.o
> 
> this is a sorted list
> 

Will fix it. Thanks for pointing it out.

> > --- /dev/null
> > +++ b/drivers/spi/davinci_spi.h
> > @@ -0,0 +1,84 @@
> > +/*
> > + * Register definitions for the DaVinci SPI Controller  */
> 
> missing license/copyright
> 

Will add copyright/license.

> > +#define spi_readl(ds, reg)					\
> > +	readl(ds->regs + DAVINCI_SPI_##reg)
> > +#define spi_writel(ds, reg, value)				\
> > +	writel(value, ds->regs + DAVINCI_SPI_##reg)
> 
> should be (ds)->regs

I'll modify it and resubmit the patch.

Thanks,
Sudhakar

  reply	other threads:[~2009-12-24  2:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23  7:44 [U-Boot] [PATCH] TI DaVinci: Driver for the davinci SPI controller Sudhakar Rajashekhara
2009-12-24  1:34 ` Mike Frysinger
2009-12-24  2:52   ` Sudhakar Rajashekhara [this message]
2009-12-25 17:11 ` Dirk Behme
2010-01-04  9:42   ` Sudhakar Rajashekhara
2010-01-04  9:46   ` Sudhakar Rajashekhara
2010-01-05  6:01     ` Mike Frysinger
2010-01-05  7:14       ` [U-Boot] NS16550 Register structure Pedanekar, Hemant
2010-01-05  7:35         ` Wolfgang Denk
2010-01-05  8:55           ` Pedanekar, Hemant
2010-01-05  9:58             ` Wolfgang Denk
2010-01-18 14:51               ` Pedanekar, Hemant
2010-01-19 13:04                 ` Detlev Zundel
2010-01-21 11:58                   ` Pedanekar, Hemant
2010-01-28  9:54                   ` Pedanekar, Hemant
2010-01-28 11:00                     ` Wolfgang Denk
2010-01-04  9:47 ` [U-Boot] [PATCH] TI DaVinci: Driver for the davinci SPI controller Nick Thompson
2010-01-04 10:42   ` Sudhakar Rajashekhara
2010-01-04 19:50     ` Dirk Behme
2010-01-05  0:20       ` Mike Frysinger
2010-03-05  6:47       ` Mansoor
2010-03-07 12:38         ` [U-Boot] OMAP3 SPI driver ( was Re: [PATCH] TI DaVinci: Driver for the davinci SPI controller) Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007301ca8444$33d9ba30$9b8d2e90$@raj@ti.com' \
    --to=sudhakar.raj@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.