All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Changhyeok Bae" <changhyeok.bae@lge.com>
To: "'Paul Eggleton'" <paul.eggleton@linux.intel.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH 2/3] gpsd: Add mirror site
Date: Thu, 24 Apr 2014 08:45:35 +0900	[thread overview]
Message-ID: <007501cf5f4e$1f74a660$5e5df320$@lge.com> (raw)
In-Reply-To: <10136853.rufA1YCh4D@peggleto-mobl5.ger.corp.intel.com>

Hi,

1. There is space between the source and target in the value.
2. Sorry, I should remove the leading +.
    However, need to ignore these patches because of martin's comment.

-----Original Message-----
From: Paul Eggleton [mailto:paul.eggleton@linux.intel.com] 
Sent: Wednesday, April 23, 2014 11:37 PM
To: Changhyeok Bae
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [oe] [meta-oe][PATCH 2/3] gpsd: Add mirror site

Hi there,

On Wednesday 23 April 2014 20:18:47 Changhyeok Bae wrote:
> * The SRC_URI is not accessible.
>   So need to add mirror site referred by the original site.
> * The problem is that
>   http://download.savannah.nongnu.org/releases redirects to closest mirror
>   and few mirrors (e.g. .jp) weren't working correctly while
>   http://download-mirror.savannah.gnu.org/releases/ seems to be reliable.
> 
> Signed-off-by: Changhyeok Bae <changhyeok.bae@lge.com>
> ---
>  meta-oe/recipes-navigation/gpsd/gpsd_3.7.bb |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta-oe/recipes-navigation/gpsd/gpsd_3.7.bb
> b/meta-oe/recipes-navigation/gpsd/gpsd_3.7.bb index 97f3354..c1b7525 
> 100644
> --- a/meta-oe/recipes-navigation/gpsd/gpsd_3.7.bb
> +++ b/meta-oe/recipes-navigation/gpsd/gpsd_3.7.bb
> @@ -22,6 +22,8 @@ SRC_URI =
> "http://download.savannah.gnu.org/releases/${PN}/${P}.tar.gz \ 
> SRC_URI[md5sum] = "52d9785eaf1a51298bb8900dbde88f98"
>  SRC_URI[sha256sum] =
> "7800c478ee9d7ca7a502b0f892828561b1fbf7bc69d9d38c447c82c3628302ac"
> 
> ++MIRRORS += "http://download.savannah.gnu.org/releases/
> http://download-mirror.savannah.gnu.org/releases/ \n" +  inherit scons 
> update-rc.d python-dir pythonnative systemd
> 
>  INITSCRIPT_NAME = "gpsd"

Sorry, but did you test these patches? For all three there seems to be no
space between the source and target in the MIRROR value, and this one has an
additional leading + that should not be there.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2014-04-23 23:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-23 11:18 [meta-oe][PATCH 1/3] fim: Add mirror site Changhyeok Bae
2014-04-23 11:18 ` [meta-oe][PATCH 2/3] gpsd: " Changhyeok Bae
2014-04-23 14:36   ` Paul Eggleton
2014-04-23 23:45     ` Changhyeok Bae [this message]
2014-04-23 11:18 ` [meta-oe][PATCH 3/3] hddtemp: " Changhyeok Bae
2014-04-23 14:45 ` [meta-oe][PATCH 1/3] fim: " Martin Jansa
2014-04-23 23:51   ` Changhyeok Bae
2014-04-24  0:00     ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007501cf5f4e$1f74a660$5e5df320$@lge.com' \
    --to=changhyeok.bae@lge.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.