From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daein Moon Subject: RE: [PATCH 1/2] ARM: S5PV310: Add support SROMC Date: Fri, 15 Oct 2010 15:37:39 +0900 Message-ID: <007c01cb6c33$7653dad0$62fb9070$@com> References: <1286972144-763-1-git-send-email-sbkim73@samsung.com> <1286972144-763-2-git-send-email-sbkim73@samsung.com> <00e301cb6ad7$3842b5c0$a8c82140$%szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:26092 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755816Ab0JOGhT (ORCPT ); Fri, 15 Oct 2010 02:37:19 -0400 Received: from epmmp1 (mailout3.samsung.com [203.254.224.33]) by mailout3.samsung.com (Sun Java(tm) System Messaging Server 7u3-15.01 64bit (built Feb 12 2010)) with ESMTP id <0LAB00JHEJQ5JM60@mailout3.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 15 Oct 2010 15:37:17 +0900 (KST) Received: from moon91243 ([12.23.102.85]) by mmp1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LAB00EVBJQ4LJ@mmp1.samsung.com> for linux-samsung-soc@vger.kernel.org; Fri, 15 Oct 2010 15:37:17 +0900 (KST) In-reply-to: <00e301cb6ad7$3842b5c0$a8c82140$%szyprowski@samsung.com> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Marek Szyprowski' , 'Sangbeom Kim' , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Cc: kgene.kim@samsung.com, ben-linux@fluff.org Marek Szyprowski wrote: > > Hello, > > On Wednesday, October 13, 2010 2:16 PM Sangbeom Kim wrote: > > > From: Daein Moon > > > > This patch adds support SROMC for S5PV310 and S5PC210. > > > > Signed-off-by: Daein Moon > > Signed-off-by: Sangbeom Kim > > --- > > arch/arm/mach-s5pv310/cpu.c | 5 ++ > > arch/arm/mach-s5pv310/include/mach/map.h | 4 ++ > > arch/arm/mach-s5pv310/include/mach/regs-srom.h | 50 > ++++++++++++++++++++++++ > > 3 files changed, 59 insertions(+), 0 deletions(-) > > create mode 100644 arch/arm/mach-s5pv310/include/mach/regs-srom.h > > > > diff --git a/arch/arm/mach-s5pv310/cpu.c b/arch/arm/mach-s5pv310/cpu.c > > index ffed262..873783a 100644 > > --- a/arch/arm/mach-s5pv310/cpu.c > > +++ b/arch/arm/mach-s5pv310/cpu.c > > @@ -81,6 +81,11 @@ static struct map_desc s5pv310_iodesc[] __initdata = > { > > .pfn = __phys_to_pfn(S3C_PA_UART), > > .length = SZ_512K, > > .type = MT_DEVICE, > > + }, { > > + .virtual = (unsigned long)S5P_VA_SROMC, > > + .pfn = __phys_to_pfn(S5PV310_PA_SROMC), > > + .length = SZ_4K, > > + .type = MT_DEVICE, > > }, > > }; > > Do You really need to make a permanent mapping for the SROMC area? Cannot the > setup code in the mach-smdk*.c call ioremap(S5PV310_PA_SROMC) and put the address it > got to the ethernet device? This area will be probably useless for boards other than > SMDK. > Hi, It seems to be useless because only ethernet device uses the SROM interface. Will this mapping be ready for devices that will use the SROM interface in boards other than SMDK? Best regards, Daein Moon > > > Best regards > -- > Marek Szyprowski > Samsung Poland R&D Center > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: moon9124@samsung.com (Daein Moon) Date: Fri, 15 Oct 2010 15:37:39 +0900 Subject: [PATCH 1/2] ARM: S5PV310: Add support SROMC In-Reply-To: <00e301cb6ad7$3842b5c0$a8c82140$%szyprowski@samsung.com> References: <1286972144-763-1-git-send-email-sbkim73@samsung.com> <1286972144-763-2-git-send-email-sbkim73@samsung.com> <00e301cb6ad7$3842b5c0$a8c82140$%szyprowski@samsung.com> Message-ID: <007c01cb6c33$7653dad0$62fb9070$@com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Marek Szyprowski wrote: > > Hello, > > On Wednesday, October 13, 2010 2:16 PM Sangbeom Kim wrote: > > > From: Daein Moon > > > > This patch adds support SROMC for S5PV310 and S5PC210. > > > > Signed-off-by: Daein Moon > > Signed-off-by: Sangbeom Kim > > --- > > arch/arm/mach-s5pv310/cpu.c | 5 ++ > > arch/arm/mach-s5pv310/include/mach/map.h | 4 ++ > > arch/arm/mach-s5pv310/include/mach/regs-srom.h | 50 > ++++++++++++++++++++++++ > > 3 files changed, 59 insertions(+), 0 deletions(-) > > create mode 100644 arch/arm/mach-s5pv310/include/mach/regs-srom.h > > > > diff --git a/arch/arm/mach-s5pv310/cpu.c b/arch/arm/mach-s5pv310/cpu.c > > index ffed262..873783a 100644 > > --- a/arch/arm/mach-s5pv310/cpu.c > > +++ b/arch/arm/mach-s5pv310/cpu.c > > @@ -81,6 +81,11 @@ static struct map_desc s5pv310_iodesc[] __initdata = > { > > .pfn = __phys_to_pfn(S3C_PA_UART), > > .length = SZ_512K, > > .type = MT_DEVICE, > > + }, { > > + .virtual = (unsigned long)S5P_VA_SROMC, > > + .pfn = __phys_to_pfn(S5PV310_PA_SROMC), > > + .length = SZ_4K, > > + .type = MT_DEVICE, > > }, > > }; > > Do You really need to make a permanent mapping for the SROMC area? Cannot the > setup code in the mach-smdk*.c call ioremap(S5PV310_PA_SROMC) and put the address it > got to the ethernet device? This area will be probably useless for boards other than > SMDK. > Hi, It seems to be useless because only ethernet device uses the SROM interface. Will this mapping be ready for devices that will use the SROM interface in boards other than SMDK? Best regards, Daein Moon > > > Best regards > -- > Marek Szyprowski > Samsung Poland R&D Center > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel