diff for duplicates of <007c01d5fec1$45097a90$cf1c6fb0$@samsung.com> diff --git a/a/1.txt b/N1/1.txt index 6b7ffeb..c6d6cd2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -2,142 +2,150 @@ Hello Pawel Thanks for helping in testing. > -----Original Message----- -> From: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>\r -> Sent: 20 March 2020 01:12\r -> To: Alim Akhtar <alim.akhtar@samsung.com>\r -> Cc: krzk@kernel.org; avri.altman@wdc.com; martin.petersen@oracle.com;\r -> kwmad.kim@samsung.com; stanley.chu@mediatek.com;\r -> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm-\r -> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; robh+dt@kernel.org;\r -> devicetree@vger.kernel.org; linux-scsi@vger.kernel.org\r -> Subject: Re: [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI\r -> \r -> On Thu, 2020-03-19 at 20:30 +0530, Alim Akhtar wrote:\r -> > This patch-set introduces UFS (Universal Flash Storage) host\r -> > controller support for Samsung family SoC. Mostly, it consists of UFS PHY and\r -> host specific driver.\r -> >\r -> > - Changes since v2:\r -> > * fixed build warning by kbuild test robot\r -> > * Added Reported-by tags\r -> >\r -> > - Changes since v1:\r -> > * fixed make dt_binding_check error as pointed by Rob\r -> > * Addressed Krzysztof's review comments\r -> > * Added Reviewed-by tags\r -> >\r -> >\r -> > patch 1/5: define devicetree bindings for UFS PHY patch 2/5: Adds UFS\r -> > PHY driver patch 3/5: define devicetree bindings for UFS HCI patch\r -> > 4/5: Adds Samsung UFS HCI driver patch 5/5: Enabled UFS on exynos7\r -> > platform\r -> Hi\r -> Is this compatible with Exynos7420? Looking at u-boot source code, there is\r -> Espresso7420 - isn't it the same device? Also this driver looks very similar to the\r -> one from vendor kernel sources (for my device).\r -> \r -Exynos7 and Exynos7420 are compatible and belong to same Exynos SoC series (but there are some fine differences)\r -\r -> I did tried to run this on my Exynos7420 based device (Samsung S6 Edge\r -> phone) with 5.6-rc6, to get any storage working (since it doesn't have sdcard\r -> slot).\r -> \r -I think this should work on S6 Edge, but not entirely sure, as I am not aware of the S6 H/W schematic, specially PMIC connection.\r -\r -> At first i got error in exynos_ufs_config_smu. Looking at vendor sources, on my\r -> device only secureos is able to write to those registers so i fixed it by using smc\r -> calls and driver probes fine. Will this be also supported by driver (maybe in\r -> future)?\r -> \r -> But now got another error\r -> [ 1.610464] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\r -> interrupt 0x00000000\r -> [ 1.610629] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\r -> [ 1.610747] host_regs: 00000010: 00000101 00007fce 00000000 00000000\r -> [ 1.610863] host_regs: 00000020: 00000000 00030e75 00000000 00000000\r -> [ 1.614727] host_regs: 00000030: 0000000f 00000000 00000000 00000000\r -> [ 1.621061] host_regs: 00000040: 00000000 00000000 00000000 00000000\r -> [ 1.627396] host_regs: 00000050: f8c37000 00000000 00000001 00000000\r -> [ 1.633730] host_regs: 00000060: 00000001 00000000 00000000 00000000\r -> [ 1.640065] host_regs: 00000070: f9644000 00000000 00000000 00000000\r -> [ 1.646400] host_regs: 00000080: 00000001 00000000 00000000 00000000\r -> [ 1.652734] host_regs: 00000090: 00000002 95290000 00000000 00000000\r -> [ 1.747649] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\r -> interrupt 0x00000000\r -> [ 1.747807] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\r -> [ 1.747924] host_regs: 00000010: 00000101 00007fce 00000000 00000000\r -> [ 1.748041] host_regs: 00000020: 00000000 00030e75 00000000 00000000\r -> [ 1.751909] host_regs: 00000030: 0000000f 00000000 00000000 00000000\r -> [ 1.758244] host_regs: 00000040: 00000000 00000000 00000000 00000000\r -> [ 1.764578] host_regs: 00000050: f8c37000 00000000 00000001 00000000\r -> [ 1.770913] host_regs: 00000060: 00000001 00000000 00000000 00000000\r -> [ 1.777248] host_regs: 00000070: f9644000 00000000 00000000 00000000\r -> [ 1.783582] host_regs: 00000080: 00000001 00000000 00000000 00000000\r -> [ 1.789917] host_regs: 00000090: 00000002 95290000 00000000 00000000\r -> [ 1.884841] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\r -> interrupt 0x00000000\r -> [ 1.884999] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\r -> [ 1.885116] host_regs: 00000010: 00000101 00007fce 00000000 00000000\r -> [ 1.885233] host_regs: 00000020: 00000000 00030e75 00000000 00000000\r -> [ 1.889100] host_regs: 00000030: 0000000f 00000000 00000000 00000000\r -> [ 1.895435] host_regs: 00000040: 00000000 00000000 00000000 00000000\r -> [ 1.901770] host_regs: 00000050: f8c37000 00000000 00000001 00000000\r -> [ 1.908104] host_regs: 00000060: 00000001 00000000 00000000 00000000\r -> [ 1.914439] host_regs: 00000070: f9644000 00000000 00000000 00000000\r -> [ 1.920773] host_regs: 00000080: 00000001 00000000 00000000 00000000\r -> [ 1.927108] host_regs: 00000090: 00000002 95290000 00000000 00000000\r -> [ 2.998155] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\r -> flag query for idn 1 failed, err = -11\r -> [ 4.502138] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\r -> flag query for idn 1 failed, err = -11\r -> [ 6.006137] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\r -> flag query for idn 1 failed, err = -11\r -> [ 6.006311] exynos-ufshc 15570000.ufs: ufshcd_query_flag_retry:\r -> query attribute, opcode 5, idn 1, failed with error -11 after 3 retires\r -> [ 6.006545] exynos-ufshc 15570000.ufs: ufshcd_complete_dev_init\r -> reading fDeviceInit flag failed with error -11\r -> \r -> Do You have any idea what could be wrong?\r -> \r -To me, It looks like UFS device is not powered ON or properly Reseted, I have seen this kind of issues in past and \r -AFAIR, fix was to keep the PMIC rail which was hook to device RESET_N always-on.\r -\r -> Thanks \r -> >\r -> > Note: This series is based on Linux-5.6-rc6 (commit: fb33c6510d55)\r -> >\r -> >\r -> > Alim Akhtar (5):\r -> > dt-bindings: phy: Document Samsung UFS PHY bindings\r -> > phy: samsung-ufs: add UFS PHY driver for samsung SoC\r -> > Documentation: devicetree: ufs: Add DT bindings for exynos UFS host\r -> > controller\r -> > scsi: ufs-exynos: add UFS host support for Exynos SoCs\r -> > arm64: dts: Add node for ufs exynos7\r -> >\r -> > .../bindings/phy/samsung,ufs-phy.yaml | 62 +\r -> > .../devicetree/bindings/ufs/ufs-exynos.txt | 104 ++\r -> > .../boot/dts/exynos/exynos7-espresso.dts | 16 +\r -> > arch/arm64/boot/dts/exynos/exynos7.dtsi | 44 +-\r -> > drivers/phy/samsung/Kconfig | 9 +\r -> > drivers/phy/samsung/Makefile | 1 +\r -> > drivers/phy/samsung/phy-exynos7-ufs.h | 85 +\r -> > drivers/phy/samsung/phy-samsung-ufs.c | 311 ++++\r -> > drivers/phy/samsung/phy-samsung-ufs.h | 100 ++\r -> > drivers/scsi/ufs/Kconfig | 12 +\r -> > drivers/scsi/ufs/Makefile | 1 +\r -> > drivers/scsi/ufs/ufs-exynos.c | 1399 +++++++++++++++++\r -> > drivers/scsi/ufs/ufs-exynos.h | 268 ++++\r -> > drivers/scsi/ufs/unipro.h | 41 +\r -> > include/linux/phy/phy-samsung-ufs.h | 70 +\r -> > 15 files changed, 2521 insertions(+), 2 deletions(-) create mode\r -> > 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml\r -> > create mode 100644\r -> > Documentation/devicetree/bindings/ufs/ufs-exynos.txt\r -> > create mode 100644 drivers/phy/samsung/phy-exynos7-ufs.h\r -> > create mode 100644 drivers/phy/samsung/phy-samsung-ufs.c\r -> > create mode 100644 drivers/phy/samsung/phy-samsung-ufs.h\r -> > create mode 100644 drivers/scsi/ufs/ufs-exynos.c create mode 100644\r -> > drivers/scsi/ufs/ufs-exynos.h create mode 100644\r -> > include/linux/phy/phy-samsung-ufs.h\r +> From: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> +> Sent: 20 March 2020 01:12 +> To: Alim Akhtar <alim.akhtar@samsung.com> +> Cc: krzk@kernel.org; avri.altman@wdc.com; martin.petersen@oracle.com; +> kwmad.kim@samsung.com; stanley.chu@mediatek.com; +> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm- +> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; robh+dt@kernel.org; +> devicetree@vger.kernel.org; linux-scsi@vger.kernel.org +> Subject: Re: [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI +> +> On Thu, 2020-03-19 at 20:30 +0530, Alim Akhtar wrote: +> > This patch-set introduces UFS (Universal Flash Storage) host +> > controller support for Samsung family SoC. Mostly, it consists of UFS PHY and +> host specific driver. > > +> > - Changes since v2: +> > * fixed build warning by kbuild test robot +> > * Added Reported-by tags +> > +> > - Changes since v1: +> > * fixed make dt_binding_check error as pointed by Rob +> > * Addressed Krzysztof's review comments +> > * Added Reviewed-by tags +> > +> > +> > patch 1/5: define devicetree bindings for UFS PHY patch 2/5: Adds UFS +> > PHY driver patch 3/5: define devicetree bindings for UFS HCI patch +> > 4/5: Adds Samsung UFS HCI driver patch 5/5: Enabled UFS on exynos7 +> > platform +> Hi +> Is this compatible with Exynos7420? Looking at u-boot source code, there is +> Espresso7420 - isn't it the same device? Also this driver looks very similar to the +> one from vendor kernel sources (for my device). +> +Exynos7 and Exynos7420 are compatible and belong to same Exynos SoC series (but there are some fine differences) + +> I did tried to run this on my Exynos7420 based device (Samsung S6 Edge +> phone) with 5.6-rc6, to get any storage working (since it doesn't have sdcard +> slot). +> +I think this should work on S6 Edge, but not entirely sure, as I am not aware of the S6 H/W schematic, specially PMIC connection. + +> At first i got error in exynos_ufs_config_smu. Looking at vendor sources, on my +> device only secureos is able to write to those registers so i fixed it by using smc +> calls and driver probes fine. Will this be also supported by driver (maybe in +> future)? +> +> But now got another error +> [ 1.610464] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled +> interrupt 0x00000000 +> [ 1.610629] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000 +> [ 1.610747] host_regs: 00000010: 00000101 00007fce 00000000 00000000 +> [ 1.610863] host_regs: 00000020: 00000000 00030e75 00000000 00000000 +> [ 1.614727] host_regs: 00000030: 0000000f 00000000 00000000 00000000 +> [ 1.621061] host_regs: 00000040: 00000000 00000000 00000000 00000000 +> [ 1.627396] host_regs: 00000050: f8c37000 00000000 00000001 00000000 +> [ 1.633730] host_regs: 00000060: 00000001 00000000 00000000 00000000 +> [ 1.640065] host_regs: 00000070: f9644000 00000000 00000000 00000000 +> [ 1.646400] host_regs: 00000080: 00000001 00000000 00000000 00000000 +> [ 1.652734] host_regs: 00000090: 00000002 95290000 00000000 00000000 +> [ 1.747649] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled +> interrupt 0x00000000 +> [ 1.747807] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000 +> [ 1.747924] host_regs: 00000010: 00000101 00007fce 00000000 00000000 +> [ 1.748041] host_regs: 00000020: 00000000 00030e75 00000000 00000000 +> [ 1.751909] host_regs: 00000030: 0000000f 00000000 00000000 00000000 +> [ 1.758244] host_regs: 00000040: 00000000 00000000 00000000 00000000 +> [ 1.764578] host_regs: 00000050: f8c37000 00000000 00000001 00000000 +> [ 1.770913] host_regs: 00000060: 00000001 00000000 00000000 00000000 +> [ 1.777248] host_regs: 00000070: f9644000 00000000 00000000 00000000 +> [ 1.783582] host_regs: 00000080: 00000001 00000000 00000000 00000000 +> [ 1.789917] host_regs: 00000090: 00000002 95290000 00000000 00000000 +> [ 1.884841] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled +> interrupt 0x00000000 +> [ 1.884999] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000 +> [ 1.885116] host_regs: 00000010: 00000101 00007fce 00000000 00000000 +> [ 1.885233] host_regs: 00000020: 00000000 00030e75 00000000 00000000 +> [ 1.889100] host_regs: 00000030: 0000000f 00000000 00000000 00000000 +> [ 1.895435] host_regs: 00000040: 00000000 00000000 00000000 00000000 +> [ 1.901770] host_regs: 00000050: f8c37000 00000000 00000001 00000000 +> [ 1.908104] host_regs: 00000060: 00000001 00000000 00000000 00000000 +> [ 1.914439] host_regs: 00000070: f9644000 00000000 00000000 00000000 +> [ 1.920773] host_regs: 00000080: 00000001 00000000 00000000 00000000 +> [ 1.927108] host_regs: 00000090: 00000002 95290000 00000000 00000000 +> [ 2.998155] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending +> flag query for idn 1 failed, err = -11 +> [ 4.502138] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending +> flag query for idn 1 failed, err = -11 +> [ 6.006137] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending +> flag query for idn 1 failed, err = -11 +> [ 6.006311] exynos-ufshc 15570000.ufs: ufshcd_query_flag_retry: +> query attribute, opcode 5, idn 1, failed with error -11 after 3 retires +> [ 6.006545] exynos-ufshc 15570000.ufs: ufshcd_complete_dev_init +> reading fDeviceInit flag failed with error -11 +> +> Do You have any idea what could be wrong? +> +To me, It looks like UFS device is not powered ON or properly Reseted, I have seen this kind of issues in past and +AFAIR, fix was to keep the PMIC rail which was hook to device RESET_N always-on. + +> Thanks +> > +> > Note: This series is based on Linux-5.6-rc6 (commit: fb33c6510d55) +> > +> > +> > Alim Akhtar (5): +> > dt-bindings: phy: Document Samsung UFS PHY bindings +> > phy: samsung-ufs: add UFS PHY driver for samsung SoC +> > Documentation: devicetree: ufs: Add DT bindings for exynos UFS host +> > controller +> > scsi: ufs-exynos: add UFS host support for Exynos SoCs +> > arm64: dts: Add node for ufs exynos7 +> > +> > .../bindings/phy/samsung,ufs-phy.yaml | 62 + +> > .../devicetree/bindings/ufs/ufs-exynos.txt | 104 ++ +> > .../boot/dts/exynos/exynos7-espresso.dts | 16 + +> > arch/arm64/boot/dts/exynos/exynos7.dtsi | 44 +- +> > drivers/phy/samsung/Kconfig | 9 + +> > drivers/phy/samsung/Makefile | 1 + +> > drivers/phy/samsung/phy-exynos7-ufs.h | 85 + +> > drivers/phy/samsung/phy-samsung-ufs.c | 311 ++++ +> > drivers/phy/samsung/phy-samsung-ufs.h | 100 ++ +> > drivers/scsi/ufs/Kconfig | 12 + +> > drivers/scsi/ufs/Makefile | 1 + +> > drivers/scsi/ufs/ufs-exynos.c | 1399 +++++++++++++++++ +> > drivers/scsi/ufs/ufs-exynos.h | 268 ++++ +> > drivers/scsi/ufs/unipro.h | 41 + +> > include/linux/phy/phy-samsung-ufs.h | 70 + +> > 15 files changed, 2521 insertions(+), 2 deletions(-) create mode +> > 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml +> > create mode 100644 +> > Documentation/devicetree/bindings/ufs/ufs-exynos.txt +> > create mode 100644 drivers/phy/samsung/phy-exynos7-ufs.h +> > create mode 100644 drivers/phy/samsung/phy-samsung-ufs.c +> > create mode 100644 drivers/phy/samsung/phy-samsung-ufs.h +> > create mode 100644 drivers/scsi/ufs/ufs-exynos.c create mode 100644 +> > drivers/scsi/ufs/ufs-exynos.h create mode 100644 +> > include/linux/phy/phy-samsung-ufs.h +> > + + + + +_______________________________________________ +linux-arm-kernel mailing list +linux-arm-kernel@lists.infradead.org +http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/a/content_digest b/N1/content_digest index acaa2f5..fd9e95b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -5,162 +5,170 @@ "Subject\0RE: [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI\0" "Date\0Fri, 20 Mar 2020 19:40:08 +0530\0" "To\0'Pawe\305\202 Chmiel' <pawel.mikolaj.chmiel@gmail.com>\0" - "Cc\0<krzk@kernel.org>" - <avri.altman@wdc.com> - <martin.petersen@oracle.com> - <kwmad.kim@samsung.com> - <stanley.chu@mediatek.com> - <cang@codeaurora.org> - <linux-samsung-soc@vger.kernel.org> - <linux-arm-kernel@lists.infradead.org> - <linux-kernel@vger.kernel.org> - <robh+dt@kernel.org> - <devicetree@vger.kernel.org> - " <linux-scsi@vger.kernel.org>\0" + "Cc\0devicetree@vger.kernel.org" + linux-samsung-soc@vger.kernel.org + robh+dt@kernel.org + martin.petersen@oracle.com + linux-kernel@vger.kernel.org + krzk@kernel.org + kwmad.kim@samsung.com + avri.altman@wdc.com + cang@codeaurora.org + linux-scsi@vger.kernel.org + stanley.chu@mediatek.com + " linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "Hello Pawel\n" "Thanks for helping in testing.\n" "\n" "> -----Original Message-----\n" - "> From: Pawe\305\202 Chmiel <pawel.mikolaj.chmiel@gmail.com>\r\n" - "> Sent: 20 March 2020 01:12\r\n" - "> To: Alim Akhtar <alim.akhtar@samsung.com>\r\n" - "> Cc: krzk@kernel.org; avri.altman@wdc.com; martin.petersen@oracle.com;\r\n" - "> kwmad.kim@samsung.com; stanley.chu@mediatek.com;\r\n" - "> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm-\r\n" - "> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; robh+dt@kernel.org;\r\n" - "> devicetree@vger.kernel.org; linux-scsi@vger.kernel.org\r\n" - "> Subject: Re: [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI\r\n" - "> \r\n" - "> On Thu, 2020-03-19 at 20:30 +0530, Alim Akhtar wrote:\r\n" - "> > This patch-set introduces UFS (Universal Flash Storage) host\r\n" - "> > controller support for Samsung family SoC. Mostly, it consists of UFS PHY and\r\n" - "> host specific driver.\r\n" - "> >\r\n" - "> > - Changes since v2:\r\n" - "> > * fixed build warning by kbuild test robot\r\n" - "> > * Added Reported-by tags\r\n" - "> >\r\n" - "> > - Changes since v1:\r\n" - "> > * fixed make dt_binding_check error as pointed by Rob\r\n" - "> > * Addressed Krzysztof's review comments\r\n" - "> > * Added Reviewed-by tags\r\n" - "> >\r\n" - "> >\r\n" - "> > patch 1/5: define devicetree bindings for UFS PHY patch 2/5: Adds UFS\r\n" - "> > PHY driver patch 3/5: define devicetree bindings for UFS HCI patch\r\n" - "> > 4/5: Adds Samsung UFS HCI driver patch 5/5: Enabled UFS on exynos7\r\n" - "> > platform\r\n" - "> Hi\r\n" - "> Is this compatible with Exynos7420? Looking at u-boot source code, there is\r\n" - "> Espresso7420 - isn't it the same device? Also this driver looks very similar to the\r\n" - "> one from vendor kernel sources (for my device).\r\n" - "> \r\n" - "Exynos7 and Exynos7420 are compatible and belong to same Exynos SoC series (but there are some fine differences)\r\n" - "\r\n" - "> I did tried to run this on my Exynos7420 based device (Samsung S6 Edge\r\n" - "> phone) with 5.6-rc6, to get any storage working (since it doesn't have sdcard\r\n" - "> slot).\r\n" - "> \r\n" - "I think this should work on S6 Edge, but not entirely sure, as I am not aware of the S6 H/W schematic, specially PMIC connection.\r\n" - "\r\n" - "> At first i got error in exynos_ufs_config_smu. Looking at vendor sources, on my\r\n" - "> device only secureos is able to write to those registers so i fixed it by using smc\r\n" - "> calls and driver probes fine. Will this be also supported by driver (maybe in\r\n" - "> future)?\r\n" - "> \r\n" - "> But now got another error\r\n" - "> [ 1.610464] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\r\n" - "> interrupt 0x00000000\r\n" - "> [ 1.610629] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\r\n" - "> [ 1.610747] host_regs: 00000010: 00000101 00007fce 00000000 00000000\r\n" - "> [ 1.610863] host_regs: 00000020: 00000000 00030e75 00000000 00000000\r\n" - "> [ 1.614727] host_regs: 00000030: 0000000f 00000000 00000000 00000000\r\n" - "> [ 1.621061] host_regs: 00000040: 00000000 00000000 00000000 00000000\r\n" - "> [ 1.627396] host_regs: 00000050: f8c37000 00000000 00000001 00000000\r\n" - "> [ 1.633730] host_regs: 00000060: 00000001 00000000 00000000 00000000\r\n" - "> [ 1.640065] host_regs: 00000070: f9644000 00000000 00000000 00000000\r\n" - "> [ 1.646400] host_regs: 00000080: 00000001 00000000 00000000 00000000\r\n" - "> [ 1.652734] host_regs: 00000090: 00000002 95290000 00000000 00000000\r\n" - "> [ 1.747649] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\r\n" - "> interrupt 0x00000000\r\n" - "> [ 1.747807] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\r\n" - "> [ 1.747924] host_regs: 00000010: 00000101 00007fce 00000000 00000000\r\n" - "> [ 1.748041] host_regs: 00000020: 00000000 00030e75 00000000 00000000\r\n" - "> [ 1.751909] host_regs: 00000030: 0000000f 00000000 00000000 00000000\r\n" - "> [ 1.758244] host_regs: 00000040: 00000000 00000000 00000000 00000000\r\n" - "> [ 1.764578] host_regs: 00000050: f8c37000 00000000 00000001 00000000\r\n" - "> [ 1.770913] host_regs: 00000060: 00000001 00000000 00000000 00000000\r\n" - "> [ 1.777248] host_regs: 00000070: f9644000 00000000 00000000 00000000\r\n" - "> [ 1.783582] host_regs: 00000080: 00000001 00000000 00000000 00000000\r\n" - "> [ 1.789917] host_regs: 00000090: 00000002 95290000 00000000 00000000\r\n" - "> [ 1.884841] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\r\n" - "> interrupt 0x00000000\r\n" - "> [ 1.884999] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\r\n" - "> [ 1.885116] host_regs: 00000010: 00000101 00007fce 00000000 00000000\r\n" - "> [ 1.885233] host_regs: 00000020: 00000000 00030e75 00000000 00000000\r\n" - "> [ 1.889100] host_regs: 00000030: 0000000f 00000000 00000000 00000000\r\n" - "> [ 1.895435] host_regs: 00000040: 00000000 00000000 00000000 00000000\r\n" - "> [ 1.901770] host_regs: 00000050: f8c37000 00000000 00000001 00000000\r\n" - "> [ 1.908104] host_regs: 00000060: 00000001 00000000 00000000 00000000\r\n" - "> [ 1.914439] host_regs: 00000070: f9644000 00000000 00000000 00000000\r\n" - "> [ 1.920773] host_regs: 00000080: 00000001 00000000 00000000 00000000\r\n" - "> [ 1.927108] host_regs: 00000090: 00000002 95290000 00000000 00000000\r\n" - "> [ 2.998155] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\r\n" - "> flag query for idn 1 failed, err = -11\r\n" - "> [ 4.502138] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\r\n" - "> flag query for idn 1 failed, err = -11\r\n" - "> [ 6.006137] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\r\n" - "> flag query for idn 1 failed, err = -11\r\n" - "> [ 6.006311] exynos-ufshc 15570000.ufs: ufshcd_query_flag_retry:\r\n" - "> query attribute, opcode 5, idn 1, failed with error -11 after 3 retires\r\n" - "> [ 6.006545] exynos-ufshc 15570000.ufs: ufshcd_complete_dev_init\r\n" - "> reading fDeviceInit flag failed with error -11\r\n" - "> \r\n" - "> Do You have any idea what could be wrong?\r\n" - "> \r\n" - "To me, It looks like UFS device is not powered ON or properly Reseted, I have seen this kind of issues in past and \r\n" - "AFAIR, fix was to keep the PMIC rail which was hook to device RESET_N always-on.\r\n" - "\r\n" - "> Thanks \r\n" - "> >\r\n" - "> > Note: This series is based on Linux-5.6-rc6 (commit: fb33c6510d55)\r\n" - "> >\r\n" - "> >\r\n" - "> > Alim Akhtar (5):\r\n" - "> > dt-bindings: phy: Document Samsung UFS PHY bindings\r\n" - "> > phy: samsung-ufs: add UFS PHY driver for samsung SoC\r\n" - "> > Documentation: devicetree: ufs: Add DT bindings for exynos UFS host\r\n" - "> > controller\r\n" - "> > scsi: ufs-exynos: add UFS host support for Exynos SoCs\r\n" - "> > arm64: dts: Add node for ufs exynos7\r\n" - "> >\r\n" - "> > .../bindings/phy/samsung,ufs-phy.yaml | 62 +\r\n" - "> > .../devicetree/bindings/ufs/ufs-exynos.txt | 104 ++\r\n" - "> > .../boot/dts/exynos/exynos7-espresso.dts | 16 +\r\n" - "> > arch/arm64/boot/dts/exynos/exynos7.dtsi | 44 +-\r\n" - "> > drivers/phy/samsung/Kconfig | 9 +\r\n" - "> > drivers/phy/samsung/Makefile | 1 +\r\n" - "> > drivers/phy/samsung/phy-exynos7-ufs.h | 85 +\r\n" - "> > drivers/phy/samsung/phy-samsung-ufs.c | 311 ++++\r\n" - "> > drivers/phy/samsung/phy-samsung-ufs.h | 100 ++\r\n" - "> > drivers/scsi/ufs/Kconfig | 12 +\r\n" - "> > drivers/scsi/ufs/Makefile | 1 +\r\n" - "> > drivers/scsi/ufs/ufs-exynos.c | 1399 +++++++++++++++++\r\n" - "> > drivers/scsi/ufs/ufs-exynos.h | 268 ++++\r\n" - "> > drivers/scsi/ufs/unipro.h | 41 +\r\n" - "> > include/linux/phy/phy-samsung-ufs.h | 70 +\r\n" - "> > 15 files changed, 2521 insertions(+), 2 deletions(-) create mode\r\n" - "> > 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml\r\n" - "> > create mode 100644\r\n" - "> > Documentation/devicetree/bindings/ufs/ufs-exynos.txt\r\n" - "> > create mode 100644 drivers/phy/samsung/phy-exynos7-ufs.h\r\n" - "> > create mode 100644 drivers/phy/samsung/phy-samsung-ufs.c\r\n" - "> > create mode 100644 drivers/phy/samsung/phy-samsung-ufs.h\r\n" - "> > create mode 100644 drivers/scsi/ufs/ufs-exynos.c create mode 100644\r\n" - "> > drivers/scsi/ufs/ufs-exynos.h create mode 100644\r\n" - "> > include/linux/phy/phy-samsung-ufs.h\r\n" - > > + "> From: Pawe\305\202 Chmiel <pawel.mikolaj.chmiel@gmail.com>\n" + "> Sent: 20 March 2020 01:12\n" + "> To: Alim Akhtar <alim.akhtar@samsung.com>\n" + "> Cc: krzk@kernel.org; avri.altman@wdc.com; martin.petersen@oracle.com;\n" + "> kwmad.kim@samsung.com; stanley.chu@mediatek.com;\n" + "> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm-\n" + "> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; robh+dt@kernel.org;\n" + "> devicetree@vger.kernel.org; linux-scsi@vger.kernel.org\n" + "> Subject: Re: [PATCH v3 0/5] exynos-ufs: Add support for UFS HCI\n" + "> \n" + "> On Thu, 2020-03-19 at 20:30 +0530, Alim Akhtar wrote:\n" + "> > This patch-set introduces UFS (Universal Flash Storage) host\n" + "> > controller support for Samsung family SoC. Mostly, it consists of UFS PHY and\n" + "> host specific driver.\n" + "> >\n" + "> > - Changes since v2:\n" + "> > * fixed build warning by kbuild test robot\n" + "> > * Added Reported-by tags\n" + "> >\n" + "> > - Changes since v1:\n" + "> > * fixed make dt_binding_check error as pointed by Rob\n" + "> > * Addressed Krzysztof's review comments\n" + "> > * Added Reviewed-by tags\n" + "> >\n" + "> >\n" + "> > patch 1/5: define devicetree bindings for UFS PHY patch 2/5: Adds UFS\n" + "> > PHY driver patch 3/5: define devicetree bindings for UFS HCI patch\n" + "> > 4/5: Adds Samsung UFS HCI driver patch 5/5: Enabled UFS on exynos7\n" + "> > platform\n" + "> Hi\n" + "> Is this compatible with Exynos7420? Looking at u-boot source code, there is\n" + "> Espresso7420 - isn't it the same device? Also this driver looks very similar to the\n" + "> one from vendor kernel sources (for my device).\n" + "> \n" + "Exynos7 and Exynos7420 are compatible and belong to same Exynos SoC series (but there are some fine differences)\n" + "\n" + "> I did tried to run this on my Exynos7420 based device (Samsung S6 Edge\n" + "> phone) with 5.6-rc6, to get any storage working (since it doesn't have sdcard\n" + "> slot).\n" + "> \n" + "I think this should work on S6 Edge, but not entirely sure, as I am not aware of the S6 H/W schematic, specially PMIC connection.\n" + "\n" + "> At first i got error in exynos_ufs_config_smu. Looking at vendor sources, on my\n" + "> device only secureos is able to write to those registers so i fixed it by using smc\n" + "> calls and driver probes fine. Will this be also supported by driver (maybe in\n" + "> future)?\n" + "> \n" + "> But now got another error\n" + "> [ 1.610464] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\n" + "> interrupt 0x00000000\n" + "> [ 1.610629] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\n" + "> [ 1.610747] host_regs: 00000010: 00000101 00007fce 00000000 00000000\n" + "> [ 1.610863] host_regs: 00000020: 00000000 00030e75 00000000 00000000\n" + "> [ 1.614727] host_regs: 00000030: 0000000f 00000000 00000000 00000000\n" + "> [ 1.621061] host_regs: 00000040: 00000000 00000000 00000000 00000000\n" + "> [ 1.627396] host_regs: 00000050: f8c37000 00000000 00000001 00000000\n" + "> [ 1.633730] host_regs: 00000060: 00000001 00000000 00000000 00000000\n" + "> [ 1.640065] host_regs: 00000070: f9644000 00000000 00000000 00000000\n" + "> [ 1.646400] host_regs: 00000080: 00000001 00000000 00000000 00000000\n" + "> [ 1.652734] host_regs: 00000090: 00000002 95290000 00000000 00000000\n" + "> [ 1.747649] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\n" + "> interrupt 0x00000000\n" + "> [ 1.747807] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\n" + "> [ 1.747924] host_regs: 00000010: 00000101 00007fce 00000000 00000000\n" + "> [ 1.748041] host_regs: 00000020: 00000000 00030e75 00000000 00000000\n" + "> [ 1.751909] host_regs: 00000030: 0000000f 00000000 00000000 00000000\n" + "> [ 1.758244] host_regs: 00000040: 00000000 00000000 00000000 00000000\n" + "> [ 1.764578] host_regs: 00000050: f8c37000 00000000 00000001 00000000\n" + "> [ 1.770913] host_regs: 00000060: 00000001 00000000 00000000 00000000\n" + "> [ 1.777248] host_regs: 00000070: f9644000 00000000 00000000 00000000\n" + "> [ 1.783582] host_regs: 00000080: 00000001 00000000 00000000 00000000\n" + "> [ 1.789917] host_regs: 00000090: 00000002 95290000 00000000 00000000\n" + "> [ 1.884841] exynos-ufshc 15570000.ufs: ufshcd_intr: Unhandled\n" + "> interrupt 0x00000000\n" + "> [ 1.884999] host_regs: 00000000: 0383ff0f 00000000 00000200 00000000\n" + "> [ 1.885116] host_regs: 00000010: 00000101 00007fce 00000000 00000000\n" + "> [ 1.885233] host_regs: 00000020: 00000000 00030e75 00000000 00000000\n" + "> [ 1.889100] host_regs: 00000030: 0000000f 00000000 00000000 00000000\n" + "> [ 1.895435] host_regs: 00000040: 00000000 00000000 00000000 00000000\n" + "> [ 1.901770] host_regs: 00000050: f8c37000 00000000 00000001 00000000\n" + "> [ 1.908104] host_regs: 00000060: 00000001 00000000 00000000 00000000\n" + "> [ 1.914439] host_regs: 00000070: f9644000 00000000 00000000 00000000\n" + "> [ 1.920773] host_regs: 00000080: 00000001 00000000 00000000 00000000\n" + "> [ 1.927108] host_regs: 00000090: 00000002 95290000 00000000 00000000\n" + "> [ 2.998155] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\n" + "> flag query for idn 1 failed, err = -11\n" + "> [ 4.502138] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\n" + "> flag query for idn 1 failed, err = -11\n" + "> [ 6.006137] exynos-ufshc 15570000.ufs: ufshcd_query_flag: Sending\n" + "> flag query for idn 1 failed, err = -11\n" + "> [ 6.006311] exynos-ufshc 15570000.ufs: ufshcd_query_flag_retry:\n" + "> query attribute, opcode 5, idn 1, failed with error -11 after 3 retires\n" + "> [ 6.006545] exynos-ufshc 15570000.ufs: ufshcd_complete_dev_init\n" + "> reading fDeviceInit flag failed with error -11\n" + "> \n" + "> Do You have any idea what could be wrong?\n" + "> \n" + "To me, It looks like UFS device is not powered ON or properly Reseted, I have seen this kind of issues in past and \n" + "AFAIR, fix was to keep the PMIC rail which was hook to device RESET_N always-on.\n" + "\n" + "> Thanks \n" + "> >\n" + "> > Note: This series is based on Linux-5.6-rc6 (commit: fb33c6510d55)\n" + "> >\n" + "> >\n" + "> > Alim Akhtar (5):\n" + "> > dt-bindings: phy: Document Samsung UFS PHY bindings\n" + "> > phy: samsung-ufs: add UFS PHY driver for samsung SoC\n" + "> > Documentation: devicetree: ufs: Add DT bindings for exynos UFS host\n" + "> > controller\n" + "> > scsi: ufs-exynos: add UFS host support for Exynos SoCs\n" + "> > arm64: dts: Add node for ufs exynos7\n" + "> >\n" + "> > .../bindings/phy/samsung,ufs-phy.yaml | 62 +\n" + "> > .../devicetree/bindings/ufs/ufs-exynos.txt | 104 ++\n" + "> > .../boot/dts/exynos/exynos7-espresso.dts | 16 +\n" + "> > arch/arm64/boot/dts/exynos/exynos7.dtsi | 44 +-\n" + "> > drivers/phy/samsung/Kconfig | 9 +\n" + "> > drivers/phy/samsung/Makefile | 1 +\n" + "> > drivers/phy/samsung/phy-exynos7-ufs.h | 85 +\n" + "> > drivers/phy/samsung/phy-samsung-ufs.c | 311 ++++\n" + "> > drivers/phy/samsung/phy-samsung-ufs.h | 100 ++\n" + "> > drivers/scsi/ufs/Kconfig | 12 +\n" + "> > drivers/scsi/ufs/Makefile | 1 +\n" + "> > drivers/scsi/ufs/ufs-exynos.c | 1399 +++++++++++++++++\n" + "> > drivers/scsi/ufs/ufs-exynos.h | 268 ++++\n" + "> > drivers/scsi/ufs/unipro.h | 41 +\n" + "> > include/linux/phy/phy-samsung-ufs.h | 70 +\n" + "> > 15 files changed, 2521 insertions(+), 2 deletions(-) create mode\n" + "> > 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml\n" + "> > create mode 100644\n" + "> > Documentation/devicetree/bindings/ufs/ufs-exynos.txt\n" + "> > create mode 100644 drivers/phy/samsung/phy-exynos7-ufs.h\n" + "> > create mode 100644 drivers/phy/samsung/phy-samsung-ufs.c\n" + "> > create mode 100644 drivers/phy/samsung/phy-samsung-ufs.h\n" + "> > create mode 100644 drivers/scsi/ufs/ufs-exynos.c create mode 100644\n" + "> > drivers/scsi/ufs/ufs-exynos.h create mode 100644\n" + "> > include/linux/phy/phy-samsung-ufs.h\n" + "> >\n" + "\n" + "\n" + "\n" + "\n" + "_______________________________________________\n" + "linux-arm-kernel mailing list\n" + "linux-arm-kernel@lists.infradead.org\n" + http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -2072d54c71c3f03ad6512d7df756df7e6b440a58f3861371273cfa9a768264f1 +e5dda37cbec91762491510c330726c713769899ffe7b1f26695b2692f3e0a236
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.