All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Serge Kuznetsov" <sk@deeptown.org>
To: "Arnaldo Carvalho de Melo" <acme@conectiva.com.br>
Cc: <linux-kernel@vger.kernel.org>, <linux-net@vger.kernel.org>
Subject: Re: [NET] Possible bug in netif_receive_skb
Date: Fri, 15 Nov 2002 09:10:24 -0500	[thread overview]
Message-ID: <007e01c28cb0$bde52900$9c094d8e@wcom.ca> (raw)
In-Reply-To: 20021114180022.GF14579@conectiva.com.br

> Em Thu, Nov 14, 2002 at 12:12:07PM -0500, Serge Kuznetsov escreveu:
> 
> > PS: BTW, how to check if skb has been freed ? I didn't found any function for
> > it. Is it possible to add the flag, like skb->freed ?
> 
> Enable slab poisoning.
> 

  Can I check if skb->users is not zero, it mean function hasn't been freed? Or just forget about it?

  But what's happen if someone's ->func will return NET_RX_DROP, but not called the kfree_skb ? Is it not good to check for it?
Why should we trust for that function, may be someone forget to do it? 

PS: Sorry, if my this questions hurts anyone, but for last almost 10 years, I'm using the Linux, I like it so much, and I want improve it and make it better, as much as possible.


All the Best!
Serge.

  reply	other threads:[~2002-11-15 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-14 17:12 [NET] Possible bug in netif_receive_skb Serge Kuznetsov
2002-11-14 17:26 ` David S. Miller
2002-11-14 20:15   ` Serge Kuznetsov
2002-11-14 18:00 ` Arnaldo Carvalho de Melo
2002-11-15 14:10   ` Serge Kuznetsov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2002-11-14 21:05 Serge Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='007e01c28cb0$bde52900$9c094d8e@wcom.ca' \
    --to=sk@deeptown.org \
    --cc=acme@conectiva.com.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.