From: "Ted Kaminski" <mouschi@wi.rr.com>
To: <linux-kernel@vger.kernel.org>
Subject: pnp/IDE question- help fixing up a patch
Date: Wed, 11 Dec 2002 23:01:47 -0600 [thread overview]
Message-ID: <007e01c2a19b$934e9a00$6400a8c0@win01> (raw)
Hello all,
I've got an ide, and an idepnp question... (for 2.4)
I'm working on refining a patch sent previously
(http://groups.google.com/groups?selm=20021108061020.A14168%40localhost) to
be less intrusive. I'll be refering to things done in that patch...
The short of it is, this sb16 pnpide interface apparently cannot use
ALTSTATUS at a certain point. (I'm no ide whiz, I'm just simplifying the
code that David Meybohm wrote, so maybe I'm off a bit) at any rate, this
seems to require a new flag be listed along with the hardware information.
His solution was to add
+ int no_passive; /* no passive status tests */
to hw_reg_s in ide.h and check that flag in drive_is_ready()
I *think* it's out of place. It seems to me it'd be more appropriate to add
+ unsigned no_passive : 1; /* no passive status tests */
to hwif_s in ide.h. Right next to a few other bitfields
Which is better? or is there a different, even better spot?
As for the idepnp part, he added a "dev = NULL" into the loop, and was
unsure of whether or not this was a good idea. I have the same question.
Or perhaps this smells of a seperate patch?
I'd rather ask these question in the form of my own patch, but... I'm a bit
short on time, atm. sorry.
Thanks in advace,
-Ted
next reply other threads:[~2002-12-12 4:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-12 5:01 Ted Kaminski [this message]
2002-12-12 8:33 ` pnp/IDE question- help fixing up a patch Andre Hedrick
2002-12-20 21:16 ` David Meybohm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='007e01c2a19b$934e9a00$6400a8c0@win01' \
--to=mouschi@wi.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.