From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH v2 2/2] tty: serial: samsung: Clean-up selection of number of available UARTs Date: Sun, 09 Nov 2014 13:39:00 +0900 Message-ID: <008101cffbd7$16c03770$4440a650$@kernel.org> References: <1412181777-6388-1-git-send-email-a.kesavan@samsung.com> <1412181777-6388-2-git-send-email-a.kesavan@samsung.com> <041301cff29a$5c9a5fa0$15cf1ee0$@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:35166 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbaKIEjG (ORCPT ); Sat, 8 Nov 2014 23:39:06 -0500 Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NER00FZ98X3UO90@mailout1.samsung.com> for linux-samsung-soc@vger.kernel.org; Sun, 09 Nov 2014 13:39:03 +0900 (KST) In-reply-to: Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Abhilash Kesavan' , 'Kukjin Kim' Cc: 'linux-arm-kernel' , gregkh@linuxfoundation.org, 'linux-samsung-soc' , 'Tomasz Figa' , 'Arnd Bergmann' Abhilash Kesavan wrote: > > On Mon, Nov 3, 2014 at 1:51 PM, Abhilash Kesavan > wrote: > > Hello Kukjin, > > > > On Fri, Oct 31, 2014 at 8:06 AM, Abhilash Kesavan > > wrote: > >> Hi Kukjin, > >> > >> On Tue, Oct 28, 2014 at 5:56 PM, Abhilash Kesavan > >> wrote: > >>> Hi Kukjin > >>> > >>> On Tue, Oct 28, 2014 at 4:01 PM, Kukjin Kim wrote: > >>>> Abhilash Kesavan wrote: > >>>>> > >>>> Hi, > >>>> > >>>> Sorry for late response. > >>>> > >>>>> Remove symbols SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS which > >>>>> select the number of UART ports available on the SoC. Replace the usage > >>>>> of SERIAL_SAMSUNG_UARTS in the serial driver with the maximum number of > >>>> > >>>> Well, as you know the number of uart ports are different on each Samsung SoCs > >>>> so I don't think just using maximum number of uart ports are possible for new > >>>> exynos7 SoC at this moment. > >>> > >>> Thanks for the review. > >>> The main reason for me sending this patch was so that we may be able > >>> to re-use the serial driver on arm64 based Exynos7 too. The two > >>> symbols mentioned above which depend on PLAT_SAMSUNG prevent this. I > >>> initially sent a patch which changed the dependency to SERIAL_SAMSUNG > >>> for these 2 symbols. However, Tomasz suggested that a clean-up of > >>> these two symbols would be a better option. > >>> > >>> Please see the discussion of the previous version here: > >>> https://lkml.org/lkml/2014/9/29/702 > >>> > >>> Can you please let me know if the previous version is acceptable ? > >> > >> Kukjin, can you please indicate the approach you would like me to > >> take. Without this serial support is blocked on Exynos7. > > > > Gentle reminder on this. > > Hi Kukjin, > Hi Abhilash, > I don't mean to nag, but this another reminder to review this. Yeah, it's no problem for me ;) > Please let me know if you are too busy to have a look at this or > require some more inputs from me. > Since I'm still having some objection on 2nd version, how about keeping current config options for serial for now and changing the dependency to SERIAL_SAMSUNG? And if required later, we can look into removal these config options later. Thanks, Kukjin From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene@kernel.org (Kukjin Kim) Date: Sun, 09 Nov 2014 13:39:00 +0900 Subject: [PATCH v2 2/2] tty: serial: samsung: Clean-up selection of number of available UARTs In-Reply-To: References: <1412181777-6388-1-git-send-email-a.kesavan@samsung.com> <1412181777-6388-2-git-send-email-a.kesavan@samsung.com> <041301cff29a$5c9a5fa0$15cf1ee0$@kernel.org> Message-ID: <008101cffbd7$16c03770$4440a650$@kernel.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Abhilash Kesavan wrote: > > On Mon, Nov 3, 2014 at 1:51 PM, Abhilash Kesavan > wrote: > > Hello Kukjin, > > > > On Fri, Oct 31, 2014 at 8:06 AM, Abhilash Kesavan > > wrote: > >> Hi Kukjin, > >> > >> On Tue, Oct 28, 2014 at 5:56 PM, Abhilash Kesavan > >> wrote: > >>> Hi Kukjin > >>> > >>> On Tue, Oct 28, 2014 at 4:01 PM, Kukjin Kim wrote: > >>>> Abhilash Kesavan wrote: > >>>>> > >>>> Hi, > >>>> > >>>> Sorry for late response. > >>>> > >>>>> Remove symbols SERIAL_SAMSUNG_UARTS_4 and SERIAL_SAMSUNG_UARTS which > >>>>> select the number of UART ports available on the SoC. Replace the usage > >>>>> of SERIAL_SAMSUNG_UARTS in the serial driver with the maximum number of > >>>> > >>>> Well, as you know the number of uart ports are different on each Samsung SoCs > >>>> so I don't think just using maximum number of uart ports are possible for new > >>>> exynos7 SoC at this moment. > >>> > >>> Thanks for the review. > >>> The main reason for me sending this patch was so that we may be able > >>> to re-use the serial driver on arm64 based Exynos7 too. The two > >>> symbols mentioned above which depend on PLAT_SAMSUNG prevent this. I > >>> initially sent a patch which changed the dependency to SERIAL_SAMSUNG > >>> for these 2 symbols. However, Tomasz suggested that a clean-up of > >>> these two symbols would be a better option. > >>> > >>> Please see the discussion of the previous version here: > >>> https://lkml.org/lkml/2014/9/29/702 > >>> > >>> Can you please let me know if the previous version is acceptable ? > >> > >> Kukjin, can you please indicate the approach you would like me to > >> take. Without this serial support is blocked on Exynos7. > > > > Gentle reminder on this. > > Hi Kukjin, > Hi Abhilash, > I don't mean to nag, but this another reminder to review this. Yeah, it's no problem for me ;) > Please let me know if you are too busy to have a look at this or > require some more inputs from me. > Since I'm still having some objection on 2nd version, how about keeping current config options for serial for now and changing the dependency to SERIAL_SAMSUNG? And if required later, we can look into removal these config options later. Thanks, Kukjin