From: Ulf Samuelsson <ulf@atmel.com>
To: buildroot@busybox.net
Subject: [Buildroot] libmad-0.15.1b fails on build
Date: Fri, 24 Aug 2007 15:29:22 +0200 [thread overview]
Message-ID: <008301c7e653$84c251f0$4b04c63e@atmel.com> (raw)
In-Reply-To: f90898420708240326v49be5083g287fbf4ffb961c8b@mail.gmail.com
----- Original Message -----
From: "Simon Pasch" <fpasch@googlemail.com>
To: <buildroot@uclibc.org>
Sent: Friday, August 24, 2007 12:26 PM
Subject: [Buildroot] libmad-0.15.1b fails on build
> Libmad fails to build for x86 (likely for other architectures too)
> because of the avr32-optimization-patch.
>
> If you don't intend to build libmad for avr32, simply removing the patch helps.
>
>
> Perhaps it would make sense to make the patch depend on the chosen
> architecture. Don't know how this is solved in other packages. I tried
> it with the folowing patch. (To keep the patch simple I manually
> renamed the file "libmad-0.15.1b-avr32-optimization.patch" to
> "libmad-0.15.1b-avr32-optimization.avr32_patch")
>
>
> --- buildroot.old/package/libmad/libmad.mk 2007-08-24 09:15:35.000000000 +0200
> +++ buildroot/package/libmad/libmad.mk 2007-08-24 12:10:43.000000000 +0200
> @@ -16,6 +16,9 @@
> $(LIBMAD_DIR)/.unpacked: $(DL_DIR)/$(LIBMAD_SOURCE)
> $(LIBMAD_CAT) $(DL_DIR)/$(LIBMAD_SOURCE) | tar -C $(BUILD_DIR)
> $(TAR_OPTIONS) -
> $(CONFIG_UPDATE) $(LIBMAD_DIR)
> +ifeq ($(strip $(BR2_avr32)),y)
> + toolchain/patch-kernel.sh $(LIBMAD_DIR) package/libmad/
> libmad-$(LIBMAD_VERSION)\*.avr32_patch\*
> +endif
> toolchain/patch-kernel.sh $(LIBMAD_DIR) package/libmad/
> libmad-$(LIBMAD_VERSION)\*.patch\*
> touch $@
>
> Didn't have the time...but it seems, that the mplayer-package has some
> avr32-only optimizations too
I think it would be better to generalize and do the following:
toolchain/patch-kernel.sh $(LIBMAD_DIR) package/libmad/ libmad-$(LIBMAD_VERSION)\*.patch
as usual, followed by:
toolchain/patch-kernel.sh $(LIBMAD_DIR) package/libmad/ libmad-$(LIBMAD_VERSION)\*.patch.$(ARCH)
Best Regards
Ulf Samuelsson
next prev parent reply other threads:[~2007-08-24 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 10:26 [Buildroot] libmad-0.15.1b fails on build Simon Pasch
2007-08-24 13:29 ` Ulf Samuelsson [this message]
2007-08-24 13:40 ` Thiago A. Corrêa
-- strict thread matches above, loose matches on Subject: below --
2007-08-22 7:03 Rolf Blindheim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008301c7e653$84c251f0$4b04c63e@atmel.com' \
--to=ulf@atmel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.