From: Pavel Fedin <p.fedin@samsung.com>
To: "'Michael S. Tsirkin'" <mst@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vhost: Fix aborting if KVM does not support eventfds
Date: Mon, 16 Nov 2015 10:31:10 +0300 [thread overview]
Message-ID: <008501d12040$c3ed4e40$4bc7eac0$@samsung.com> (raw)
In-Reply-To: <20151116091242-mutt-send-email-mst@redhat.com>
Hello!
> OK so it's a misconfigured kernel.
> Fine but I'm not happy with silently using userspace instead.
It's not silent. You get two warnings in the log:
--- cut ---
2015-11-13T08:43:51.146802Z qemu-system-aarch64: KVM does not support MMIO eventfds
2015-11-13T08:43:51.146915Z qemu-system-aarch64: unable to start vhost net: 38: falling back on userspace virtio
--- cut ---
> If people ask for vhost they should get it.
> How about
> - kicking vhost from userspace
This can be interesting, this would be similar to forwarding IRQ through the userspace if we don't have irqfds. But i believe this
would require a lot to implement. To tell the truth, i'm not ready for this.
Actually, for now i just want to provide some way to switch kernels and use the same userspace configuration, and make all possible
conbinations working somehow, without critical faults. Anyway, if we want to use vhost, i suppose we want to get maximum
performance, which can not be achieved with userspace event forwarding, so it's IMHO okay just to fallback to userspace (which we
already do, just we miss to catch some situations), just explain why.
I even plan to add another warning, when eventfds work and irqfds don't. Currently we just silently fall back to userspace IRQ
forwarding.
> or
> - failing vhost init
That's what my patch does. vhost_dev_enable_notifiers () is called from within vhost-net init routine. I intentionally patch
vhost.c so that it should also have the same effect on vhost-scsi.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-11-16 7:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 9:28 [Qemu-devel] [PATCH] vhost: Fix aborting if KVM does not support eventfds Pavel Fedin
2015-11-14 19:18 ` Michael S. Tsirkin
2015-11-16 7:02 ` Pavel Fedin
2015-11-16 7:16 ` Michael S. Tsirkin
2015-11-16 7:31 ` Pavel Fedin [this message]
2015-11-16 14:34 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008501d12040$c3ed4e40$4bc7eac0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.