From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'David Miller' <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org,
dm-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
leedom-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
santosh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
kumaras-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
Subject: RE: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4
Date: Wed, 12 Mar 2014 14:57:49 -0500 [thread overview]
Message-ID: <008601cf3e2d$583b5e90$08b21bb0$@opengridcomputing.com> (raw)
In-Reply-To: <20140312.155125.1045693666130935765.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
> -----Original Message-----
> From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org]
> Sent: Wednesday, March 12, 2014 2:51 PM
> To: hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
> Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org;
> dm-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org; swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org; leedom-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org;
> santosh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org; kumaras-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org; nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
> Subject: Re: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4
>
> From: Hariprasad Shenai <hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> Date: Wed, 12 Mar 2014 21:20:15 +0530
>
> > V6:
> > In patch 8/31, move the existing neigh_release() call right before the
> > if(!e) test, that way you don't need a completely new label and code block
> > to fix this bug - thanks to review by David Miller
> > In patch 15/31, use %pad to print dma_addr - thanks to review by Joe Perches
> > In patch 10/31, add the "STOPPED" state string to db_state_str - thanks
> > to review by Steve Wise
> > In patch 10/31, t4_db_dropped() needs to disable dbs and send DB_FULL
> > event to iw_cxgb4 - thanks to review by Steve Wise
> > V5:
> > Dropped patch "cxgb4: use spinlock_irqsave/spinlock_irqrestore for db lock".
>
> I do not see the spinlock patch reinstated, part of it was correct and
> fixed a real bug. For the second time, I only stated that parts of it
> were superfluous, not all of it.
>
Ok we can reinstate this patch and remove the bits from 10/31 if that's what you prefer.
Steve.
BTW: From my earlier reply explaining that we didn't drop the needed fixes:
The remaining changes from the removed patch are moved into patch 10/31
(Doorbell Drop Avoidance Bug Fixes). 10/31 has the driver call
disable_txq_db() from an interrupt handler, and I thought it would be
better to put all the changes to fix how the db lock is acquired into
this one patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: "'David Miller'" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
<hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
Cc: <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
<roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org>,
<dm-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
<leedom-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
<santosh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
<kumaras-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>,
<nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
Subject: RE: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4
Date: Wed, 12 Mar 2014 14:57:49 -0500 [thread overview]
Message-ID: <008601cf3e2d$583b5e90$08b21bb0$@opengridcomputing.com> (raw)
In-Reply-To: <20140312.155125.1045693666130935765.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
> -----Original Message-----
> From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org]
> Sent: Wednesday, March 12, 2014 2:51 PM
> To: hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
> Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org;
> dm-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org; swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org; leedom-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org;
> santosh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org; kumaras-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org; nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
> Subject: Re: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4
>
> From: Hariprasad Shenai <hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> Date: Wed, 12 Mar 2014 21:20:15 +0530
>
> > V6:
> > In patch 8/31, move the existing neigh_release() call right before the
> > if(!e) test, that way you don't need a completely new label and code block
> > to fix this bug - thanks to review by David Miller
> > In patch 15/31, use %pad to print dma_addr - thanks to review by Joe Perches
> > In patch 10/31, add the "STOPPED" state string to db_state_str - thanks
> > to review by Steve Wise
> > In patch 10/31, t4_db_dropped() needs to disable dbs and send DB_FULL
> > event to iw_cxgb4 - thanks to review by Steve Wise
> > V5:
> > Dropped patch "cxgb4: use spinlock_irqsave/spinlock_irqrestore for db lock".
>
> I do not see the spinlock patch reinstated, part of it was correct and
> fixed a real bug. For the second time, I only stated that parts of it
> were superfluous, not all of it.
>
Ok we can reinstate this patch and remove the bits from 10/31 if that's what you prefer.
Steve.
BTW: From my earlier reply explaining that we didn't drop the needed fixes:
The remaining changes from the removed patch are moved into patch 10/31
(Doorbell Drop Avoidance Bug Fixes). 10/31 has the driver call
disable_txq_db() from an interrupt handler, and I thought it would be
better to put all the changes to fix how the db lock is acquired into
this one patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-12 19:57 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 15:50 [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4 Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 01/31] cxgb4: Fix some small bugs in t4_sge_init_soft() when our Page Size is 64KB Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 02/31] cxgb4: Add code to dump SGE registers when hitting idma hangs Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 03/31] cxgb4: Rectify emitting messages about SGE Ingress DMA channels being potentially stuck Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 04/31] cxgb4: Updates for T5 SGE's Egress Congestion Threshold Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 05/31] cxgb4: Calculate len properly for LSO path Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 06/31] iw_cxgb4: cap CQ size at T4_MAX_IQ_SIZE Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 07/31] iw_cxgb4: Allow loopback connections Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 08/31] iw_cxgb4: release neigh entry Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 09/31] iw_cxgb4: Treat CPL_ERR_KEEPALV_NEG_ADVICE as negative advice Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 10/31] cxgb4/iw_cxgb4: Doorbell Drop Avoidance Bug Fixes Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 11/31] iw_cxgb4: use the BAR2/WC path for kernel QPs and T5 devices Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 12/31] iw_cxgb4: Fix incorrect BUG_ON conditions Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 13/31] iw_cxgb4: Mind the sq_sig_all/sq_sig_type QP attributes Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 14/31] iw_cxgb4: default peer2peer mode to 1 Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 16/31] iw_cxgb4: don't leak skb in c4iw_uld_rx_handler() Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 17/31] iw_cxgb4: fix possible memory leak in RX_PKT processing Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 18/31] iw_cxgb4: ignore read reponse type 1 CQEs Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 19/31] iw_cxgb4: connect_request_upcall fixes Hariprasad Shenai
[not found] ` <1394639446-6504-1-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-12 15:50 ` [PATCHv6 net-next 15/31] iw_cxgb4: save the correct map length for fast_reg_page_lists Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 20/31] iw_cxgb4: adjust tcp snd/rcv window based on link speed Hariprasad Shenai
[not found] ` <1394639446-6504-21-git-send-email-hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-12 19:50 ` David Miller
[not found] ` <20140312.155017.118512327402563943.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-03-12 20:08 ` Steve Wise
2014-03-12 20:08 ` Steve Wise
2014-03-12 20:23 ` David Miller
[not found] ` <20140312.162348.2225551653125401290.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-03-12 21:29 ` Steve Wise
2014-03-12 21:29 ` Steve Wise
2014-03-12 22:12 ` David Miller
[not found] ` <20140312.181245.1921772176964395946.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-03-12 22:57 ` Steve Wise
2014-03-12 22:57 ` Steve Wise
2014-03-12 15:50 ` [PATCHv6 net-next 21/31] iw_cxgb4: update snd_seq when sending MPA messages Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 29/31] iw_cxgb4: minor fixes Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 31/31] iw_cxgb4: Use pr_warn_ratelimited Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 22/31] iw_cxgb4: lock around accept/reject downcalls Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 23/31] iw_cxgb4: drop RX_DATA packets if the endpoint is gone Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 24/31] iw_cxgb4: rx_data() needs to hold the ep mutex Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 25/31] iw_cxgb4: endpoint timeout fixes Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 26/31] iw_cxgb4: rmb() after reading valid gen bit Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 27/31] iw_cxgb4: wc_wmb() needed after DB writes Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 28/31] iw_cxgb4: SQ flush fix Hariprasad Shenai
2014-03-12 15:50 ` [PATCHv6 net-next 30/31] iw_cxgb4: Max fastreg depth depends on DSGL support Hariprasad Shenai
2014-03-12 19:51 ` [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4 David Miller
[not found] ` <20140312.155125.1045693666130935765.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-03-12 19:57 ` Steve Wise [this message]
2014-03-12 19:57 ` Steve Wise
2014-03-12 23:48 ` Casey Leedom
[not found] ` <03F31BF5-3DB6-4199-8DAB-A97BFB35D35F@chelsio.com>
[not found] ` <03F31BF5-3DB6-4199-8DAB-A97BFB35D35F-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2014-03-12 23:52 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008601cf3e2d$583b5e90$08b21bb0$@opengridcomputing.com' \
--to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dm-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=hariprasad-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=kumaras-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=leedom-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=nirranjan-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=roland-BHEL68pLQRGGvPXPguhicg@public.gmane.org \
--cc=santosh-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.