From mboxrd@z Thu Jan 1 00:00:00 1970 From: Byungho An Subject: RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver Date: Sat, 22 Mar 2014 15:23:41 -0700 Message-ID: <008901cf461d$63cbf2e0$2b63d8a0$@samsung.com> References: <007f01cf4597$50abac40$f20304c0$@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.samsung.com ([203.254.224.33]:17024 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbaCVWXu (ORCPT ); Sat, 22 Mar 2014 18:23:50 -0400 In-reply-to: Content-language: en-us Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: 'Vince Bridgers' Cc: netdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, 'David Miller' , 'GIRISH K S' , 'SIVAREDDY KALLAM' , 'Vipul Chandrakant' , 'Ilho Lee' , 'Jay Bhat' Vince Bridgers : > On Sat, Mar 22, 2014 at 1:23 AM, Byungho An wrote: > > From: Siva Reddy > > > > This patch adds support for Samsung 10Gb ethernet driver(sxgbe). > > [snip] > > +static int sxgbe_init_rx_buffers(struct net_device *dev, > > + struct sxgbe_rx_norm_desc *p, int i, > > + unsigned int dma_buf_sz, > > + struct sxgbe_rx_queue *rx_ring) > > +{ > > + struct sxgbe_priv_data *priv = netdev_priv(dev); > > + struct sk_buff *skb; > > + > > + skb = __netdev_alloc_skb(dev, dma_buf_sz, GFP_KERNEL); > > + if (!skb) > > + return -ENOMEM; > > + > > + skb_reserve(skb, NET_IP_ALIGN); > > Considering using netdev_alloc_skb_ip_align here as well. Looks like > it was changed in refill, but not here OK. Thanks > > -- > > To unsubscribe from this list: send the line "unsubscribe netdev" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html