From: "John Hughes" <john@Calva.COM>
To: linux-x25@vger.kernel.org
Subject: A "fixed" version of Stéphane Fillod's xotd for Linux
Date: Mon, 9 Dec 2002 13:27:11 +0100 [thread overview]
Message-ID: <008a01c29f7e$4d02ccc0$f70127d5@britannic> (raw)
In-Reply-To: <007901c29f7c$535ed480$f70127d5@britannic>
I've been playing around with xotd-0.04 for a while and have come up
with a version that I think fixes some serious bugs, notably some
problems with lost outbound calls. (I append my earlier message
describing this problem).
It also allows configuration of multiple remote XOT devices.
---
I said:
> I'm having a little problem making Linux xotd work with my
> home grown implementation, but I think I've tracked it down
> to a difference of opinion about when the TCP call should be
> cleared.
The way xotd works is that it clears the TCP call if it
recieves an X.25 CLEAR CONFIRMATION:
void *tap_writer(void *arg)
{
...
while (1) {
nread = readn(sockfd,(unsigned char*)&header,
sizeof(struct xot_header));
if (nread != sizeof(struct xot_header)) {
...
break; /* abort */
}
...
}
if (isVerbose)
printd("TCP connection closed (tap writer),
lci=%d.",curr_lci);
hash_remove(&hash_table, sockfd, lci);
close(sockfd); /* TODO: add to a spare list,
for use by tap_reader */
This seems reasonable. *BUT* if xotd SENDS a CLEAR CONFIRMATION,
in the other direction it does not clear the call, it keeps it
open and will re-use it for new connections. (It used to clear
the call, but as of version 0.04 this is commented out).
Now imagine what happens when two of these xotd's are talking
together -
xotd#1 xotd#2
send clear conf >----\
\----------> Get clear conf
|
/--------< Clear TCP call
Send new call >----\ /
\ /
X
/
Eurgh <---/
Whoops! the new call has been sent on a socket that has been
closed by the other side.
next parent reply other threads:[~2002-12-09 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <007901c29f7c$535ed480$f70127d5@britannic>
2002-12-09 12:27 ` John Hughes [this message]
2002-12-18 19:12 ` PVCs on X.25? Ricardo Dias Cassali
2002-12-18 19:51 ` Arnaldo Carvalho de Melo
2002-12-09 12:14 RE : A "fixed" version of Stéphane Fillod's xotd for Linux John Hughes
2002-12-09 12:20 ` Ian Cass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008a01c29f7e$4d02ccc0$f70127d5@britannic' \
--to=john@calva.com \
--cc=linux-x25@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.