From: Gur Stavi <gur.stavi@huawei.com>
To: 'Bjorn Helgaas' <helgaas@kernel.org>
Cc: "Gongfan (Eric, Chip)" <gongfan1@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>, <linux-doc@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Cai Huoqing <cai.huoqing@linux.dev>,
"Guoxin (D)" <guoxin09@huawei.com>,
shenchenyang <shenchenyang1@hisilicon.com>,
"zhoushuai (A)" <zhoushuai28@huawei.com>,
"Wulike (Collin)" <wulike1@huawei.com>,
"shijing (A)" <shijing34@huawei.com>,
Meny Yossefi <meny.yossefi@huawei.com>
Subject: RE: [RFC net-next v02 1/3] net: hinic3: module initialization and tx/rx logic
Date: Sun, 15 Dec 2024 10:59:36 +0200 [thread overview]
Message-ID: <008b01db4ecf$b529e4a0$1f7dade0$@huawei.com> (raw)
In-Reply-To: <20241212170256.GA3347301@bhelgaas>
> Is the PPF selected dynamically by the driver? By firmware on the
> NIC?
Selected dynamically by PF driver but initial submission only contains
VF logic.
> > + # Fields of HW and management structures are little endian and will
> not
> > + # be explicitly converted
>
> I guess this comment is here to explain the !CPU_BIG_ENDIAN below?
> That's quite an unusual dependency.
>
Yes. Otherwise the code will be swamped with cpu_to_le and le_to_cpu.
Microsoft and Amazon drivers have it as well. I wonder if all other
drivers were tested on big endian host.
Dependency on CPU_LITTLE_ENDIAN would be nicer but unfortunately x86
arch does not define it.
> > + depends on 64BIT && !CPU_BIG_ENDIAN
>
Other comments were addressed in files for next submission.
next prev parent reply other threads:[~2024-12-15 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 12:04 [RFC net-next v02 0/3] net: hinic3: Add a driver for Huawei 3rd gen NIC Gur Stavi
2024-12-12 12:04 ` [RFC net-next v02 1/3] net: hinic3: module initialization and tx/rx logic Gur Stavi
2024-12-12 17:02 ` Bjorn Helgaas
2024-12-15 8:59 ` Gur Stavi [this message]
2024-12-12 17:41 ` Andrew Lunn
2024-12-19 8:55 ` Gur Stavi
2024-12-19 8:46 ` Andrew Lunn
2024-12-19 9:28 ` Gur Stavi
2024-12-12 12:04 ` [RFC net-next v02 2/3] net: hinic3: management interfaces Gur Stavi
2024-12-12 12:04 ` [RFC net-next v02 3/3] net: hinic3: sw and hw initialization code Gur Stavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008b01db4ecf$b529e4a0$1f7dade0$@huawei.com' \
--to=gur.stavi@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=cai.huoqing@linux.dev \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gongfan1@huawei.com \
--cc=guoxin09@huawei.com \
--cc=helgaas@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=meny.yossefi@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shenchenyang1@hisilicon.com \
--cc=shijing34@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.