From: "Jongsung Kim" <neidhard.kim@lge.com>
To: "'Francois Romieu'" <romieu@fr.zoreil.com>
Cc: <davem@davemloft.net>, <peppe.cavallaro@st.com>,
<chohnstaedt@innominate.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: RE: net: phy: realtek: add rtl8201f driver
Date: Thu, 9 May 2013 11:26:05 +0900 [thread overview]
Message-ID: <008c01ce4c5c$8f572bc0$ae058340$@lge.com> (raw)
In-Reply-To: <20130508104119.GA24905@electric-eye.fr.zoreil.com>
Francois Romieu <romieu@fr.zoreil.com> :
> Your patch contains both "remove unused #define" and "support new
hardware"
> parts. I am not sure that the former is adequate for submission until
net-next opens.
I see. Sorry for trying touching them even without comment. I won't touch
them.
> static void rtl8201f_page_select(struct phy_device *phydev, int page) ?
Okay. Looks better..
>> + if(phy_driver_register(&rtl8201f_driver) < 0)
> ^^ -> missing space.
What a shame!
> You may use an array of phy_driver for realtek_{init/exit}
Agreed.
--
Ueimor
next prev parent reply other threads:[~2013-05-09 2:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 10:10 net: phy: realtek: add rtl8201f driver Jongsung Kim
2013-05-08 10:41 ` Francois Romieu
2013-05-09 2:26 ` Jongsung Kim [this message]
2013-05-08 15:43 ` Sergei Shtylyov
2013-05-09 2:35 ` Jongsung Kim
2013-05-09 16:58 ` Sergei Shtylyov
2013-05-10 3:44 ` Jongsung Kim
2013-05-10 7:29 ` [PATCH v2 1/4] net: phy: realtek: simplify multiple drivers registration Jongsung Kim
2013-05-10 7:29 ` [PATCH v2 2/4] net: phy: realtek: add support for the RTL8201F Jongsung Kim
2013-05-10 7:29 ` [PATCH v2 3/4] net: phy: realtek: add suspend/resume handlers for the RTL8211B Jongsung Kim
2013-05-10 7:29 ` [PATCH v2 4/4] net: phy: realtek: cleanup code Jongsung Kim
2013-05-10 11:18 ` Sergei Shtylyov
2013-05-13 2:48 ` Jongsung Kim
2013-05-13 9:58 ` [PATCH v3 1/4] net: phy: realtek: simplify multiple drivers registration Jongsung Kim
2013-05-13 9:58 ` [PATCH v3 2/4] net: phy: realtek: add support for the RTL8201F Jongsung Kim
2013-05-13 9:58 ` [PATCH v3 3/4] net: phy: realtek: add suspend/resume handlers for the RTL8211B Jongsung Kim
2013-05-13 9:58 ` [PATCH v3 4/4] net: phy: realtek: cleanup code Jongsung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='008c01ce4c5c$8f572bc0$ae058340$@lge.com' \
--to=neidhard.kim@lge.com \
--cc=chohnstaedt@innominate.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.