All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Chaithrika U S" <chaithrika@ti.com>
To: alsa-devel@alsa-project.org
Cc: khilman@deeprootsystems.com,
	davinci-linux-open-source@linux.davincidsp.com,
	broonie@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: DaVinci: Fix stream restart error
Date: Wed, 20 Jan 2010 17:37:05 +0530	[thread overview]
Message-ID: <008d01ca99c9$14f83ed0$3ee8bc70$@com> (raw)
In-Reply-To: <1263987285-29775-1-git-send-email-alsa-devel@alsa-project.org>

All,

Please ignore this patch, missed the 'To' address in the mail.
I have re-submitted this patch.

Regards, 
Chaithrika

On Wed, Jan 20, 2010 at 17:04:45, alsa-devel@alsa-project.org wrote:
> From: Chaithrika U S <chaithrika@ti.com>
> 
> Sometimes after a suspend-resume cycle, the ALSA application
> restarts the stream when resume fails and McASP fails to work
> as the clock is not enabled. This patch corrects this bug.
> 
> Testes on TI DA850/OMAP-L138 EVM.
> 
> Signed-off-by: Chaithrika U S <chaithrika@ti.com>
> ---
> Applies to ALSA GIT tree on branch topic/asoc at
> http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=shortlog;
> h=topic/asoc
> 
>  sound/soc/davinci/davinci-mcasp.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index a613bbb..ab6518d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -768,13 +768,12 @@ static int davinci_mcasp_trigger(struct snd_pcm_substream *substream,
>  
>  	switch (cmd) {
>  	case SNDRV_PCM_TRIGGER_RESUME:
> +	case SNDRV_PCM_TRIGGER_START:
> +	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>  		if (!dev->clk_active) {
>  			clk_enable(dev->clk);
>  			dev->clk_active = 1;
>  		}
> -		/* Fall through */
> -	case SNDRV_PCM_TRIGGER_START:
> -	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
>  		davinci_mcasp_start(dev, substream->stream);
>  		break;
>  
> -- 
> 1.5.6
> 

       reply	other threads:[~2010-01-20 12:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1263987285-29775-1-git-send-email-alsa-devel@alsa-project.org>
2010-01-20 12:07 ` Chaithrika U S [this message]
2010-01-20 11:36 [PATCH] ASoC: DaVinci: Fix stream restart error Chaithrika U S
2010-01-26 12:42 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='008d01ca99c9$14f83ed0$3ee8bc70$@com' \
    --to=chaithrika@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=khilman@deeprootsystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.