All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul Fulghum" <paulkf@microgate.com>
To: <klaus.herb@ikon-gmbh.de>, <linux-kernel@vger.kernel.org>
Subject: Re: ppp_synctty and in_interrupt
Date: Thu, 13 Jun 2002 10:06:00 -0500	[thread overview]
Message-ID: <009101c212eb$d460e690$0c00a8c0@diemos> (raw)
In-Reply-To: <01C212F6.F1993680.klaus.herb@ikon-gmbh.de>

> I am currently developing a tty-Driver which is used for synchronous PPP.
> ...
> The ppp_synctty ldisc only calls my ttywrite function in interrupt
context.
> But to avoid a race condition I must include a Semaphore in my ttywrite
> function, so I get a Kernel Oops when this Semaphore causes a call to
> schedule().
>
> Is there a way to stop this ppp_synctty ldisc from sending in Interrupt
> Context?
> or
> Why does this ldisc only write in interrupt context?
>
> Please CC your replay to klaus.herb@ikon-gmbh.de

It should not call the tty write function in interrupt context.

The ldisc will call the tty write in two situtations:
1. when a new packet to send is available
2. when the tty driver calls the ldisc write_wakeup
  to send queued frames

My guess is that your driver is calling write_wakeup
in an interrupt context (in response to a tx complete IRQ).
You should call write_wakeup() from a bottom half
handler scheduled by the interrupt service routine instead
of directly from the ISR.

Paul Fulghum, paulkf@microgate.com
Microgate Corporation, www.microgate.com


      reply	other threads:[~2002-06-13 15:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-13 14:25 ppp_synctty and in_interrupt Klaus Herb
2002-06-13 15:06 ` Paul Fulghum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='009101c212eb$d460e690$0c00a8c0@diemos' \
    --to=paulkf@microgate.com \
    --cc=klaus.herb@ikon-gmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.