Re: [dpdk-dev] [PATCH v5 15/24] net/ngbe: add Rx queue setup and release

["Jiawen Wu" <jiawenwu@trustnetic.com>]

On Tuesday, June 15, 2021 2:53 AM, Andrew Rybchenko wrote:
> On 6/2/21 12:40 PM, Jiawen Wu wrote:
> > Setup device Rx queue and release Rx queue.
> >
> > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
> > ---
> >   drivers/net/ngbe/ngbe_ethdev.c |   9 +
> >   drivers/net/ngbe/ngbe_ethdev.h |   8 +
> >   drivers/net/ngbe/ngbe_rxtx.c   | 305
> +++++++++++++++++++++++++++++++++
> >   drivers/net/ngbe/ngbe_rxtx.h   |  90 ++++++++++
> >   4 files changed, 412 insertions(+)
> >
> > diff --git a/drivers/net/ngbe/ngbe_rxtx.h
> > b/drivers/net/ngbe/ngbe_rxtx.h index 39011ee286..e1676a53b4 100644
> > --- a/drivers/net/ngbe/ngbe_rxtx.h
> > +++ b/drivers/net/ngbe/ngbe_rxtx.h
> > @@ -6,7 +6,97 @@
> >   #ifndef _NGBE_RXTX_H_
> >   #define _NGBE_RXTX_H_
> >
> > +/*****************************************************************************
> > + * Receive Descriptor
> > + *****************************************************************************/
> > +struct ngbe_rx_desc {
> > +	struct {
> > +		union {
> > +			__le32 dw0;
> 
> rte_* types shuld be used

I don't quite understand, should '__le32' be changed to 'rte_*' type?

> 
> > +			struct {
> > +				__le16 pkt;
> > +				__le16 hdr;
> > +			} lo;
> > +		};
> > +		union {
> > +			__le32 dw1;
> > +			struct {
> > +				__le16 ipid;
> > +				__le16 csum;
> > +			} hi;
> > +		};
> > +	} qw0; /* also as r.pkt_addr */
> > +	struct {
> > +		union {
> > +			__le32 dw2;
> > +			struct {
> > +				__le32 status;
> > +			} lo;
> > +		};
> > +		union {
> > +			__le32 dw3;
> > +			struct {
> > +				__le16 len;
> > +				__le16 tag;
> > +			} hi;
> > +		};
> > +	} qw1; /* also as r.hdr_addr */
> > +};
> > +