From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C791C433EF for ; Mon, 28 Feb 2022 18:05:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 32E2F1832; Mon, 28 Feb 2022 19:04:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 32E2F1832 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646071538; bh=ZuN7R19CpZ+tD0mbMD2B2m+TnP6BZbW0fRvaZAvNAhQ=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=L0BiC009U87FUTNChGTgSCAFC4OsEt62K2ag9SNgqytDt2Cj+447OIjeDjiAbq3xn IBlxe//2IXLsDG7e+VKqBjuOZDTQWPiTvObuI+NHatOa0dn/h+F52LoanXRg+JyIeI jev2TBRC1n+GYqL0UUyFq1MecakcLKhXDJkjLfJQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B98ABF8013C; Mon, 28 Feb 2022 19:04:47 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7D891F8015B; Mon, 28 Feb 2022 19:04:45 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2948CF8013C for ; Mon, 28 Feb 2022 19:04:39 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2948CF8013C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IwD2cUfd" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646071483; x=1677607483; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ZuN7R19CpZ+tD0mbMD2B2m+TnP6BZbW0fRvaZAvNAhQ=; b=IwD2cUfdBuQ9hO3EJzccL+noSS2DwKoNF+KZWdonAKHdH2YWv3+dvcN1 bi8vGpZ++SCspSZghKBt5bVPByG0mnt1OxPHQWAXbAr4SHsTVeE95YlIf 3VZRxw4CLNHYo96ybxs5ZEPoAgRgHcsqQfVj7x1l0kxgcJJHak9kOIuGF Af0j5bFXWjAC6wTBdQkiuN+hHd/vEYVbDkIb91UCWfpf25Yk0D68X8h+I btED/OjWEKZtKdw2bFrwxQ2RC1pB3XcZm6AxwtuU8JdxrOsH1lnDoTQTh 1qVN82ZH9+Jx27qtOIqq9uzE306vFN6SuV7P34hhg3HUfP+EjTNOzLaw4 g==; X-IronPort-AV: E=McAfee;i="6200,9189,10272"; a="232919505" X-IronPort-AV: E=Sophos;i="5.90,144,1643702400"; d="scan'208";a="232919505" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 10:04:35 -0800 X-IronPort-AV: E=Sophos;i="5.90,144,1643702400"; d="scan'208";a="510184833" Received: from ensymall-mobl.amr.corp.intel.com (HELO [10.212.116.28]) ([10.212.116.28]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2022 10:04:34 -0800 Message-ID: <00972101-2526-334e-c2ea-02558b93f5bf@linux.intel.com> Date: Mon, 28 Feb 2022 11:23:53 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH v2 00/17] ASoC: Intel: AVS - Audio DSP for cAVS Content-Language: en-US To: Cezary Rojewski , alsa-devel@alsa-project.org References: <20220228153343.2263412-1-cezary.rojewski@intel.com> From: Pierre-Louis Bossart In-Reply-To: <20220228153343.2263412-1-cezary.rojewski@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: upstream@semihalf.com, harshapriya.n@intel.com, rad@semihalf.com, tiwai@suse.com, hdegoede@redhat.com, broonie@kernel.org, amadeuszx.slawinski@linux.intel.com, cujomalainey@chromium.org, lma@semihalf.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > Changes v2 -> v1: > Almost all updates here are thanks to feedback from Pierre. Can I ask for a bit of mercy on reviewers and specifically my time? I sent my comments on Friday, I haven't had time to look at the answers and there's a new version already? > - several comments and few kernel-docs have been added in areas which > felt more or less unclear > - avs_ipc_wait_busy_completion() now spins up to 'repeats_left' number > of times before giving up > - 'adsp_ba' field of struct avs_dev has been renamed to 'dsp_ba' > - 'dops' field of struct avs_spec has been renamed to 'dsp_ops' > - IPC abstraction has been simplified: SKL_ADSP_REG_HIP* regs are used > directly > - fixed allnoconfig with AVS enabled compilation issues > - fixed code loading error paths: previously requested firmware is now > released before function return to the caller > - code and function arguments tied to D0IX support have been removed > from this patchset and will be part of followup series adding that > feature instead > - enriched dev_err() messages in avs_dsp_get_core() and > avs_dsp_put_core() > - numerous wording fixes used in power/reset/stall DSP operations