All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Steve Wise" <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: 'Sagi Grimberg' <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>,
	'Doug Ledford' <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: RE: [PATCH 1/2] cm: Don't allocate ib_cm workqueue with WQ_MEM_RECLAIM
Date: Tue, 15 Aug 2017 12:30:12 -0500	[thread overview]
Message-ID: <009901d315ec$263eee80$72bccb80$@opengridcomputing.com> (raw)
In-Reply-To: <1502813574-6040-2-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

> create_workqueue always creates the worqeueu with WQ_MEM_RECLAIM

Typo "worqeueu" -> "workqueue"

> and silences a flush dependancy warn for WQ_LEGACY. Instead, we
> want to keep the warn in case the allocator tries to flush the
> cm workqueue because its very likely that cm work execution will
> yield memory allocations (for example cm connection requests) .
> 
> Reported-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>

The change looks good.

Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2017-08-15 17:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-15 16:12 [PATCH 0/2] Don't allocate ib/iw cm workqueues with WQ_MEM_RECLAIM Sagi Grimberg
     [not found] ` <1502813574-6040-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-08-15 16:12   ` [PATCH 1/2] cm: Don't allocate ib_cm workqueue " Sagi Grimberg
     [not found]     ` <1502813574-6040-2-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-08-15 17:30       ` Steve Wise [this message]
2017-08-15 18:06         ` Leon Romanovsky
2017-08-15 16:12   ` [PATCH 2/2] iwcm: Don't allocate iwcm " Sagi Grimberg
     [not found]     ` <1502813574-6040-3-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
2017-08-15 17:30       ` Steve Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='009901d315ec$263eee80$72bccb80$@opengridcomputing.com' \
    --to=swise-7bpotxp6k4+p2yhjcf5u+vpxobypeauw@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.