All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Adrian Hunter'" <adrian.hunter@intel.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
	<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
	<beanhuo@micron.com>, <cang@codeaurora.org>, <sc.suh@samsung.com>,
	<hy50.seo@samsung.com>, <sh425.lee@samsung.com>,
	<bhoon95.kim@samsung.com>, <vkumar.1997@samsung.com>
Subject: RE: [PATCH v2] scsi: ufs: exclude UECxx from SFR dump list
Date: Thu, 10 Mar 2022 15:17:25 +0900	[thread overview]
Message-ID: <009901d83446$82e6d2b0$88b47810$@samsung.com> (raw)
In-Reply-To: <b2909fd3-fa5b-9471-fb9c-6f068a1ab871@intel.com>

> > These are ROC type things that means their values are cleared when the
> > SFRs are read.
> > They are usually read in ISR when an UIC error occur.
> > Thus, their values would be zero at many cases. And there might be a
> > little bit risky when they are read to be cleared before the ISR reads
> > them, e.g. the case that a command is timed-out, ufshcd_dump_regs is
> > called in ufshcd_abort and an UIC error occurs at the nearly same
> > time. In this case, ISR will be called but UFS error handler will not
> > be scheduled.
> > This patch is to make UFS driver not read those SFRs in the dump
> > function, i.e. ufshcd_dump_regs.
> 
> This is essentially a fix, so perhaps a fixes tag?
> 
> Wouldn't hurt to wrap the commit description more nicely.


Thank you for your opinion.


Thanks.
Kiwoong Kim


      reply	other threads:[~2022-03-10  6:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220308081304epcas2p4e7279fb51babf93fdf0bf0a3aacf9f68@epcas2p4.samsung.com>
2022-03-08  8:11 ` [PATCH v2] scsi: ufs: exclude UECxx from SFR dump list Kiwoong Kim
2022-03-08  8:46   ` Adrian Hunter
2022-03-10  6:17     ` Kiwoong Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='009901d83446$82e6d2b0$88b47810$@samsung.com' \
    --to=kwmad.kim@samsung.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bhoon95.kim@samsung.com \
    --cc=cang@codeaurora.org \
    --cc=hy50.seo@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sc.suh@samsung.com \
    --cc=sh425.lee@samsung.com \
    --cc=vkumar.1997@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.