Re: [PATCH] f2fs: add compat_ioctl to f2fs_dir_operations

[Chao Yu <chao2.yu@samsung.com>]

Hi Jianyang,

> -----Original Message-----
> From: hujianyang [mailto:hujianyang@huawei.com]
> Sent: Tuesday, May 12, 2015 4:06 PM
> To: Jaegeuk Kim
> Cc: Chao Yu; namjae.jeon@samsung.com; linux-f2fs-devel@lists.sourceforge.net
> Subject: [f2fs-dev][PATCH] f2fs: add compat_ioctl to f2fs_dir_operations
> 
> commit e9750824114ff939d9da299e73651add6aa65456
> 
> f2fs: add compat_ioctl to provide backward compatability
> 
> introduce compat_ioctl to regular files, but doesn't add this
> functionality to f2fs_dir_operations.
> 
> While running a 32-bit busybox, I met an error like this:
> (A is a directory)
> 
> # busybox chattr +i A
> chattr: reading flags on A: Inappropriate ioctl for device
> 
> This patch copies compat_ioctl from f2fs_file_operations and
> fix this problem.

Looks good to me.

> 
> Signed-off-by: hujianyang <hujianyang@huawei.com>

Reviewed-by: Chao Yu <chao2.yu@samsung.com>



------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y