From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: ragaprasanth@gmail.com, openembedded-core@lists.openembedded.org
Cc: bruce.ashfield@gmail.com
Subject: Re: [OE-core] [PATCH] kernel-grub.bbclass: use KERNEL_PACKAGE_NAME for the image packages
Date: Thu, 12 Nov 2026 13:15:20 +0000 [thread overview]
Message-ID: <009b6c46042e0aab4046eb4bb24efeb63a06cb96.camel@linuxfoundation.org> (raw)
In-Reply-To: <20261029060913.1586484-1-ragaprasanth@gmail.com>
On Thu, 2026-10-29 at 15:09 +0900, prasanth via lists.openembedded.org wrote:
> kernel-grub adds its scriptlets to kernel-image-<type>, but kernel.bbclass
> names these packages ${KERNEL_PACKAGE_NAME}-image-<type>. With another
> KERNEL_PACKAGE_NAME the scriptlets go to a package that does not exist,
> so they never run and the GRUB menu is not updated on a kernel upgrade.
>
> Use KERNEL_PACKAGE_NAME, as kernel.bbclass and linux-dummy.bbclass do.
>
> AI-Generated: Uses Claude
> Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp>
> ---
>
> Notes:
> Checked with bitbake -e: with KERNEL_PACKAGE_NAME set, the GRUB
> scriptlets were set on kernel-image-<type>, which is not in PACKAGES. With this
> patch they are on <KERNEL_PACKAGE_NAME>-image-<type>; the default is unchanged.
>
> meta/classes-recipe/kernel-grub.bbclass | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes-recipe/kernel-grub.bbclass b/meta/classes-recipe/kernel-grub.bbclass
> index 2325e635e1..7c6abc5b4f 100644
> --- a/meta/classes-recipe/kernel-grub.bbclass
> +++ b/meta/classes-recipe/kernel-grub.bbclass
> @@ -98,6 +98,7 @@ python __anonymous () {
> fi
> '''
>
> + kname = d.getVar('KERNEL_PACKAGE_NAME') or "kernel"
I'm afraid I'm not happy with that fallback default. If something does
change in the code paths later, I really want this to break, not have
inconsistent values. I'd therefore like to see a revised version of
this please.
Thanks,
Richard
prev parent reply other threads:[~2026-11-12 13:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 6:09 [PATCH] kernel-grub.bbclass: use KERNEL_PACKAGE_NAME for the image packages Prasanth R
2026-10-29 13:11 ` Bruce Ashfield
2026-11-04 0:27 ` Prasanth Ramesh
2026-11-04 15:15 ` Mathieu Dubois-Briand
2026-11-12 13:15 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=009b6c46042e0aab4046eb4bb24efeb63a06cb96.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bruce.ashfield@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ragaprasanth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.