diff for duplicates of <00a001d5a10d$da529670$8ef7c350$@samsung.com> diff --git a/a/1.txt b/N1/1.txt index c3db9d3..c110c15 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,26 +1,26 @@ -> >> … -> >>> +++ b/fs/exfat/dir.c -> >> … -> >>> +static int exfat_readdir(struct inode *inode, struct exfat_dir_entry -> >> *dir_entry) -> >>> +{ -> >> … -> >>> + if (!ep) { -> >>> + ret = -EIO; -> >>> + goto free_clu; -> >>> + } -> >> -> >> How do you think about to move a bit of common exception handling code -> >> (at similar places)? -> > Not sure it is good. -> -> The software development opinions can vary also for this change pattern -> according to different design goals. -> Is such a transformation just another possibility to reduce duplicate -> source code a bit? -I changed it without unnecessary goto abuse. Look at the next version later. -Thanks! -> -> Regards, +> >> …\r +> >>> +++ b/fs/exfat/dir.c\r +> >> …\r +> >>> +static int exfat_readdir(struct inode *inode, struct exfat_dir_entry\r +> >> *dir_entry)\r +> >>> +{\r +> >> …\r +> >>> + if (!ep) {\r +> >>> + ret = -EIO;\r +> >>> + goto free_clu;\r +> >>> + }\r +> >>\r +> >> How do you think about to move a bit of common exception handling code\r +> >> (at similar places)?\r +> > Not sure it is good.\r +> \r +> The software development opinions can vary also for this change pattern\r +> according to different design goals.\r +> Is such a transformation just another possibility to reduce duplicate\r +> source code a bit?\r +I changed it without unnecessary goto abuse. Look at the next version later.\r +Thanks!\r +> \r +> Regards,\r > Markus diff --git a/a/content_digest b/N1/content_digest index 95ab2e4..154da54 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\00e17c0a7-9b40-12a4-3f3f-500b9abb66de@web.de\0" "From\0Namjae Jeon <namjae.jeon@samsung.com>\0" "Subject\0RE: [PATCH v4 04/13] exfat: add directory operations\0" - "Date\0Fri, 22 Nov 2019 08:21:34 +0000\0" + "Date\0Fri, 22 Nov 2019 17:21:34 +0900\0" "To\0'Markus Elfring' <Markus.Elfring@web.de>\0" "Cc\0linux-kernel@vger.kernel.org" kernel-janitors@vger.kernel.org @@ -21,30 +21,30 @@ "\00:1\0" "b\0" "\n" - "> >> \342\200\246\n" - "> >>> +++ b/fs/exfat/dir.c\n" - "> >> \342\200\246\n" - "> >>> +static int exfat_readdir(struct inode *inode, struct exfat_dir_entry\n" - "> >> *dir_entry)\n" - "> >>> +{\n" - "> >> \342\200\246\n" - "> >>> +\t\t\tif (!ep) {\n" - "> >>> +\t\t\t\tret = -EIO;\n" - "> >>> +\t\t\t\tgoto free_clu;\n" - "> >>> +\t\t\t}\n" - "> >>\n" - "> >> How do you think about to move a bit of common exception handling code\n" - "> >> (at similar places)?\n" - "> > Not sure it is good.\n" - "> \n" - "> The software development opinions can vary also for this change pattern\n" - "> according to different design goals.\n" - "> Is such a transformation just another possibility to reduce duplicate\n" - "> source code a bit?\n" - "I changed it without unnecessary goto abuse. Look at the next version later.\n" - "Thanks!\n" - "> \n" - "> Regards,\n" + "> >> \342\200\246\r\n" + "> >>> +++ b/fs/exfat/dir.c\r\n" + "> >> \342\200\246\r\n" + "> >>> +static int exfat_readdir(struct inode *inode, struct exfat_dir_entry\r\n" + "> >> *dir_entry)\r\n" + "> >>> +{\r\n" + "> >> \342\200\246\r\n" + "> >>> +\t\t\tif (!ep) {\r\n" + "> >>> +\t\t\t\tret = -EIO;\r\n" + "> >>> +\t\t\t\tgoto free_clu;\r\n" + "> >>> +\t\t\t}\r\n" + "> >>\r\n" + "> >> How do you think about to move a bit of common exception handling code\r\n" + "> >> (at similar places)?\r\n" + "> > Not sure it is good.\r\n" + "> \r\n" + "> The software development opinions can vary also for this change pattern\r\n" + "> according to different design goals.\r\n" + "> Is such a transformation just another possibility to reduce duplicate\r\n" + "> source code a bit?\r\n" + "I changed it without unnecessary goto abuse. Look at the next version later.\r\n" + "Thanks!\r\n" + "> \r\n" + "> Regards,\r\n" > Markus -8014913356345b78e83ee3170dcad3eee683a8cddfcc07e88150b14ac2fa2790 +6f649ee7f148167747fa8be84a0fd6fcc703f17e57e3d0a6a8ef8a39d7d6a99b
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.