Re: [PATCH v1 1/2] dbus: Add support to tcp address

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 937 bytes --]

Hi Ramon,

On 04/15/2019 07:23 AM, Ramon Ribeiro wrote:
> This patch allows a dbus client to connect to a dbus-daemon server
> address listenning a TCP transport protocol.
> A non-blocking TCP socket is created to avoid blocking the main event
> loop.
> ---
>   ell/dbus.c | 151 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
>   1 file changed, 146 insertions(+), 5 deletions(-)
> 

<snip>

> +
> +	tv.tv_sec = 1;
> +	tv.tv_usec = 0;
> +
> +	// Wait until sockets be ready, otherwise a timeout is thrown
> +	if (select(fd + 1, &rfds, &wfds, NULL, &tv) == 0) {
> +		close(fd);
> +		return NULL;
> +	}

How does this help?  You're still sleeping in select and not allowing 
the main event loop to run.  You would need to setup an l_io for these 
fds (so that they're part of the main-event loop epoll_wait call) and 
wait for the connect to succeed or go on to next address.

Regards,
-Denis