From: "Madhusudhan Chikkature" <madhu.cr@ti.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org
Subject: Re: [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
Date: Thu, 3 Jul 2008 19:23:51 +0530 [thread overview]
Message-ID: <00a901c8dd14$3be88e00$69f6180a@ent.ti.com> (raw)
In-Reply-To: 60b6f36a0c398d87284f428bc42c7a79@felipebalbi.com
----- Original Message -----
From: "Felipe Balbi" <me@felipebalbi.com>
To: "Madhusudhan Chikkature" <madhu.cr@ti.com>
Cc: <tony@atomide.com>; <linux-omap@vger.kernel.org>
Sent: Thursday, July 03, 2008 6:38 PM
Subject: Re: [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430
>
>
> On Thu, 3 Jul 2008 17:35:50 +0530 (IST), "Madhusudhan Chikkature"
> <madhu.cr@ti.com> wrote:
>
>> Index: linux-omap-2.6/arch/arm/mach-omap2/bci.c
>> ===================================================================
>> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
>> +++ linux-omap-2.6/arch/arm/mach-omap2/bci.c 2008-07-03
> 16:59:40.000000000
>> +0530
>> @@ -0,0 +1,34 @@
>> +/*
>> + * linux/arch/arm/mach-omap2/board-3430sdp-bci.c
>
> just fix this name please.
Okay. I missed this one. I will correct it.
>
> Style only.
What does this mean?
>
>
>> +
>> +static struct platform_device twl4030_bci_battery_device = {
>> + .name = "twl4030-bci-battery",
>> + .id = 1,
>
> use -1. There will be no other twl4030-bci-battery in the system :-)
>
> --
> Best Regards,
>
> Felipe Balbi
> http://blog.felipebalbi.com
> me@felipebalbi.com
>
>
next prev parent reply other threads:[~2008-07-03 13:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 12:05 [Resending - PATCH 1/3] Triton BCI driver device setup for OMAP3430 Madhusudhan Chikkature
2008-07-03 13:08 ` Felipe Balbi
2008-07-03 13:53 ` Madhusudhan Chikkature [this message]
2008-07-03 14:07 ` Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2008-07-04 4:36 Madhusudhan Chikkature
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00a901c8dd14$3be88e00$69f6180a@ent.ti.com' \
--to=madhu.cr@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=me@felipebalbi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.