From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9DEFC433E0 for ; Tue, 9 Jun 2020 15:02:32 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D7D82078C for ; Tue, 9 Jun 2020 15:02:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dYMP99xQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D7D82078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiflZ-00014v-6p; Tue, 09 Jun 2020 15:02:17 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jiflX-00014l-V0 for xen-devel@lists.xenproject.org; Tue, 09 Jun 2020 15:02:16 +0000 X-Inumbo-ID: 344bf460-aa62-11ea-8496-bc764e2007e4 Received: from mail-wm1-x341.google.com (unknown [2a00:1450:4864:20::341]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 344bf460-aa62-11ea-8496-bc764e2007e4; Tue, 09 Jun 2020 15:02:15 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id u26so2520638wmn.1 for ; Tue, 09 Jun 2020 08:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:reply-to:to:cc:references:in-reply-to:subject:date:message-id :mime-version:content-transfer-encoding:content-language :thread-index; bh=s3CKbZ4cdGeIagoNQQCQIiVIGsrlCr7cr1u8QUoLxt4=; b=dYMP99xQYZ61axkZ1aiRmqNAUE8DZx7v5lRs/urVZwpSVvKmCqz3ZtnbHPbl7I25u3 iZnSP8YAkW5+9TZFEhQeBfiZh0uPDlwN05g9AK2TlfnHYfylcJwGZj69acNd8S+5nysr gz+t3sjRQuco3w5sjMmR9oWA9F9oxwhRjg93Xm1W0t8d+ML67+mdve5Gg4ws5mC8R7Zg wqBDohnvJEm3tN/iCbKvx1VshJ3G3cK+mR/BbNlMh4sP6H1SJfaku++3X0rGFEfafiZ5 EKepd3uLYNo4kXQHxOGlLvutE7mpdudhkmLK6TPJihdPGCCCJj5PgpsvSZTMgTGWlrvU DifA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:reply-to:to:cc:references:in-reply-to :subject:date:message-id:mime-version:content-transfer-encoding :content-language:thread-index; bh=s3CKbZ4cdGeIagoNQQCQIiVIGsrlCr7cr1u8QUoLxt4=; b=kV0beImUvwq65cUSg2epOiKnxj9in8Z4imsDxxSxuZo4maqNfR7LP5N4QafmZ7O3hI n0/EDSkHG14yvdc49q6sZRWIBQ8QBGWOv02HmBchUQdwI/uOfl2HUt+m5IkPVKRGKg11 XhmMMF1FubQAVW13XXOqqHS2UHCIggOmF61kgvzObKt7etIip9JhPZFnZgGalA0Mz1eI iD/7ZOK81dm0R3Q0vOg/qcKU3boJHWZca/tkgw8nWZX+iHUv0fVL7N92fuB4EPCHXpzt vFxL5EhTWDT0+Aktkcg5PNBQzp3H3t4ZbFCjB8wIg1DQOIq1kkZXWHa24MSOhIm++Ci5 XK8w== X-Gm-Message-State: AOAM530A+ON/bBBxVDq2jK6WWfyrDQ9mjNNFRBShB9RxSoJja3sq/r2L qb6dsvTMb96z5ys94f2LRaQ= X-Google-Smtp-Source: ABdhPJyJSwCN73oqHMgDEMu3k6AQHAjeKG8Ru1IXuvtymI0h65sLL7HTsSpxUkutxF6Tqn3Z9hwfUA== X-Received: by 2002:a1c:6509:: with SMTP id z9mr4754852wmb.144.1591714934559; Tue, 09 Jun 2020 08:02:14 -0700 (PDT) Received: from CBGR90WXYV0 ([54.239.6.185]) by smtp.gmail.com with ESMTPSA id 50sm3961168wra.1.2020.06.09.08.02.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Jun 2020 08:02:14 -0700 (PDT) From: Paul Durrant X-Google-Original-From: "Paul Durrant" To: "'Juergen Gross'" , References: <20200609144850.28619-1-jgross@suse.com> <20200609144850.28619-3-jgross@suse.com> In-Reply-To: <20200609144850.28619-3-jgross@suse.com> Subject: RE: [PATCH for-4.14 2/2] tools: fix setting of errno in xenhypfs_read_raw() Date: Tue, 9 Jun 2020 16:02:12 +0100 Message-ID: <00ac01d63e6e$f58224c0$e0866e40$@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-gb Thread-Index: AQJImk/I1P2ywCrTN6Alqf97EMn8vwHT/j8hp90JTqA= X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Reply-To: paul@xen.org Cc: 'Ian Jackson' , 'George Dunlap' , 'Wei Liu' Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" > -----Original Message----- > From: Juergen Gross > Sent: 09 June 2020 15:49 > To: xen-devel@lists.xenproject.org > Cc: paul@xen.org; Juergen Gross ; Ian Jackson ; Wei Liu > ; George Dunlap > Subject: [PATCH for-4.14 2/2] tools: fix setting of errno in xenhypfs_read_raw() > > Setting of errno is wrong in xenhypfs_read_raw(), fix it. > > Reported-by: George Dunlap > Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant Release-acked-by: Paul Durrant > --- > tools/libs/hypfs/core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/tools/libs/hypfs/core.c b/tools/libs/hypfs/core.c > index fc23b02586..f94c5ea1e2 100644 > --- a/tools/libs/hypfs/core.c > +++ b/tools/libs/hypfs/core.c > @@ -241,10 +241,8 @@ void *xenhypfs_read_raw(xenhypfs_handle *fshdl, const char *path, > if (!ret) > break; > > - if (ret != ENOBUFS) { > - errno = -ret; > + if (errno != ENOBUFS) > goto out; > - } > } > > content = malloc(entry->content_len); > -- > 2.26.2