Re: [PATCH v2 2/2] arm64: zynqmp: Add ifm ZynqMP VHIP6 EvalBoard

[Marek Vasut <marex@nabladev.com>]

On 9/13/26 4:27 PM, Peter Korsgaard wrote:

Hi,

>   >> > +	chosen {
>   >> > +		bootargs = "clk_ignore_unused";
>   >> Why?
> 
>   > This can be dropped, thanks.
> 
> Good.
> 
>   >> > +	gpio-line-names =
>   >> > +		/* GPIO 0 - 77 */
>   >> > +		"", "", "", "", "", "", "", "", "", "",	"", "", "", "", "", "",
>   >> > +		"", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "",
>   >> > +		"", "", "", "", "",
>   >> > +		"ifm_device_info_eeprom_wp",
>   >> NIT: The dts references a number of other GPIOs, any specific reason
>   >> to
>   >> only name this one?
>   > The legacy userspace tooling used to depend on it, used libgpiod to
>   > look up this GPIO by name.
> 
> OK, but why not add all the referenced GPIOs if you fill out
> gpio-line-names anyway?
Because the userspace depends only on this one line name. But since 
eeprom node contains wp-gpios DT property now and the kernel controls 
the nWP GPIO, I can also turn this around and drop the gpio-line-names 
entirely. What do you think ?

Thank you for your help !