From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 979AEC4332F for ; Thu, 9 Nov 2023 03:34:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 57871871C6; Thu, 9 Nov 2023 04:34:08 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=rock-chips.com header.i=@rock-chips.com header.b="dQZqowJm"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5AD2F871C6; Thu, 9 Nov 2023 04:34:03 +0100 (CET) Received: from mail-m24125.xmail.ntesmail.com (mail-m24125.xmail.ntesmail.com [45.195.24.125]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A637B871C6 for ; Thu, 9 Nov 2023 04:33:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com DKIM-Signature: a=rsa-sha256; b=dQZqowJmV1+ikkCibhkALuH+e8+q6dXAyEIHUphnXBBa7JYzusLaaVVvGNSCH/YzwH+jcv9mb8GQKmWBjF/A2v372hx4QtNAMGTErwf/50b1RU0ctj684mBAC8x2bykSMvbQxSpGp34oV8LkgxgZEIm283qUtRgaFF7HiR9NalM=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=CWDi2v3iR1arJs4icccufeZgrTvq4tDKmfyst+oXilY=; h=date:mime-version:subject:message-id:from; Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11877.qiye.163.com (Hmail) with ESMTPA id C96B04002AD; Thu, 9 Nov 2023 11:33:53 +0800 (CST) Message-ID: <00ae8f97-dd6f-476e-9cdf-64d6c129827e@rock-chips.com> Date: Thu, 9 Nov 2023 11:33:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/6] rockchip: ringneck-px30: only declare functions in U-Boot proper Content-Language: en-US To: Quentin Schulz , Joe Hershberger , Klaus Goger , Simon Glass , Philipp Tomsich Cc: u-boot@lists.denx.de, Heiko Stuebner , Quentin Schulz References: <20231108-env_default_theobroma-v1-0-cb493bfdeffd@theobroma-systems.com> <20231108-env_default_theobroma-v1-4-cb493bfdeffd@theobroma-systems.com> From: Kever Yang In-Reply-To: <20231108-env_default_theobroma-v1-4-cb493bfdeffd@theobroma-systems.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQxlLSlZCSBhOS0hPSE9CTExVEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk5MSUpJVUpLS1VKQl kG X-HM-Tid: 0a8bb224bcea2eb3kusnc96b04002ad X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OAw6Ojo*HjwwTAg4NUhRTDwK TRUwCTlVSlVKTUJCTktLQ0hPTkJIVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFJQktCNwY+ X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/11/8 22:20, Quentin Schulz wrote: > From: Quentin Schulz > > Those functions are useless in anything but U-Boot proper for now, so > let's compile them out explicitly. > > Cc: Quentin Schulz > Signed-off-by: Quentin Schulz Reviewed-by: Kever Yang Thanks, - Kever > --- > board/theobroma-systems/ringneck_px30/ringneck-px30.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/board/theobroma-systems/ringneck_px30/ringneck-px30.c b/board/theobroma-systems/ringneck_px30/ringneck-px30.c > index bb1bb4acf5c..dd711cd05de 100644 > --- a/board/theobroma-systems/ringneck_px30/ringneck-px30.c > +++ b/board/theobroma-systems/ringneck_px30/ringneck-px30.c > @@ -25,6 +25,7 @@ > #include > #include > > +#ifndef CONFIG_SPL_BUILD > /* > * Swap mmc0 and mmc1 in boot_targets if booted from SD-Card. > * > @@ -169,3 +170,4 @@ int misc_init_r(void) > > return 0; > } > +#endif >