From: Nicolai Buchwitz <nb@tipi-net.de>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: "Conor Dooley" <conor.dooley@microchip.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Russell King" <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Paolo Valerio" <pvalerio@redhat.com>,
"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>,
"Benoît Monin" <benoit.monin@bootlin.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH net-next v6 2/2] net: macb: distribute evenly Tx SRAM segments
Date: Sun, 15 Nov 2026 20:40:55 +0100 [thread overview]
Message-ID: <00aea741bd079eb9168fb2ef9b656f25@tipi-net.de> (raw)
In-Reply-To: <20261113-macb-set-channels-v6-2-5de59d9e7f02@bootlin.com>
On 13.11.2026 18:32, Théo Lebrun wrote:
> GEM has registers to configure the Tx SRAM segments distribution across
> queues. The reset value is apprioriate (even spread) but we need to
> care if/when number of active queues is modified (or if we inherited
> unevenly initialised hardware from bootloader).
>
> To distribute segments, we take as input the number of queues
> (ctx->num_queues) and the number of segments (found inside DCFG6).
> Its output is a number of segments for each queue, formatted as
> powers-of-two (eg 2 for queue 0 means it has 2^2=4 segments).
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
> ---
> drivers/net/ethernet/cadence/macb.h | 14 ++++++
> drivers/net/ethernet/cadence/macb_main.c | 76
> +++++++++++++++++++++++++++++++-
> [...]
> static void macb_init_hw(struct macb *bp)
> {
> u32 config;
> @@ -3465,6 +3522,20 @@ static void macb_init_hw(struct macb *bp)
> if (bp->caps & MACB_CAPS_JUMBO)
> bp->rx_frm_len_mask = MACB_RX_JFRMLEN_MASK;
>
> + /* Distribute Tx SRAM segments evenly based on active number of
> queues.
> + * TXQSEGALLOC is only documented for some GEM integrations.
> + */
> + if (bp->caps & MACB_CAPS_TXQSEGALLOC) {
> + unsigned int num_segments;
> + u32 val;
> +
> + num_segments = 1U << GEM_BFEXT(SEGMENTS_BIT_SIZE,
> + gem_readl(bp, DCFG6));
> + val = gem_sram_distribute_segments(bp->ctx->num_queues,
> + num_segments);
> + gem_writel(bp, TXQSEGALLOC_LOWER, val);
This only runs on open, not on a context swap. So ethtool -L on a
running interface keeps the old split until the next down/up?
> [...]
Regards,
Nicolai
next prev parent reply other threads:[~2026-11-15 19:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 17:32 [PATCH net-next v6 0/2] net: macb: implement ethtool set channels count operation Théo Lebrun
2026-11-13 17:32 ` [PATCH net-next v6 1/2] net: macb: implement ethtool_ops.get|set_channels() Théo Lebrun
2026-11-15 19:39 ` Nicolai Buchwitz
2026-11-17 10:20 ` Théo Lebrun
2026-11-17 19:43 ` netdev-bot+sashiko
2026-11-13 17:32 ` [PATCH net-next v6 2/2] net: macb: distribute evenly Tx SRAM segments Théo Lebrun
2026-11-13 18:18 ` Théo Lebrun
2026-11-15 19:40 ` Nicolai Buchwitz [this message]
2026-11-17 10:23 ` Théo Lebrun
2026-11-17 19:43 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00aea741bd079eb9168fb2ef9b656f25@tipi-net.de \
--to=nb@tipi-net.de \
--cc=andrew+netdev@lunn.ch \
--cc=benoit.monin@bootlin.com \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pvalerio@redhat.com \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.