All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Schmidt <s.schmidt@samsung.com>
To: 'Alexander Aring' <alex.aring@gmail.com>, linux-wpan@vger.kernel.org
Subject: Re: [PATCHv2 wpan-tools 1/2] interface: remove twice phy information
Date: Tue, 20 Jan 2015 20:30:10 +0000	[thread overview]
Message-ID: <00b001d034ef$e350dd20$a9f29760$@samsung.com> (raw)
In-Reply-To: <1421784155-2670-1-git-send-email-alex.aring@gmail.com>

Hello.

On 20/01/15 21:02, Alexander Aring wrote:
> The phy information is already shown in a previous printout and this
> code seems that it was never be functional.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>   src/interface.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/src/interface.c b/src/interface.c
> index 095753b..904b96e 100644
> --- a/src/interface.c
> +++ b/src/interface.c
> @@ -212,8 +212,6 @@ static int print_iface_handler(struct nl_msg *msg,
> void *arg)
>
> le16toh(nla_get_u16(tb_msg[NL802154_ATTR_PAN_ID])));
>   	if (tb_msg[NL802154_ATTR_IFTYPE])
>   		printf("%s\ttype %s\n", indent,
> iftype_name(nla_get_u32(tb_msg[NL802154_ATTR_IFTYPE])));
> -	if (!wpan_phy && tb_msg[NL802154_ATTR_WPAN_PHY])
> -		printf("%s\twpan_phy %d\n", indent,
> nla_get_u32(tb_msg[NL802154_ATTR_WPAN_PHY]));
>   	if (tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES])
>   		printf("%s\tmax_frame_retries %d\n", indent,
> nla_get_s8(tb_msg[NL802154_ATTR_MAX_FRAME_RETRIES]));
>   	if (tb_msg[NL802154_ATTR_MIN_BE])
>

Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>

regards
Stefan Schmidt



      parent reply	other threads:[~2015-01-20 20:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 20:02 [PATCHv2 wpan-tools 1/2] interface: remove twice phy information Alexander Aring
2015-01-20 20:02 ` [PATCHv2 wpan-tools 2/2] info: remove unused features argument Alexander Aring
2015-01-20 20:30   ` Stefan Schmidt
2015-01-20 20:30 ` Stefan Schmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='00b001d034ef$e350dd20$a9f29760$@samsung.com' \
    --to=s.schmidt@samsung.com \
    --cc=alex.aring@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.