RE: [PATCH v10 00/17] Wangxun fixes and new features

["Zaiyu Wang" <zaiyuwang@trustnetic.com>]

> Most of it is fine, but you still are keeping a driver specific behavior around PHY control which was identified as not acceptable
in an earlier review.
> 
> I object to cases where driver writers treat their PMD as a unique and special case because that would end up tying the user
application to a
> specific PMD and it makes it harder for users to manage and write code.
> 
> If there is a missing feature in the ethdev management layer, then control operations and offloads should be added there and
drivers should all
> work against that.
> 
> The current AI review reflects that.
> 
Hi Stephen,

Thanks for your review. I accept both points, and v11 has been posted with
the corresponding fixes.

Now the laser_off devarg is gone, along with its documentation and release
note entry. Tx is now disabled unconditionally when an AML40 port goes
down, and link setup runs again on link-up to restore what link-down disabled. 

You are right that set_link_up() is a control operation and the application asked
for the link to come back up so renegotiation is the cost of that. There is nothing
missing in ethdev here either. set_link_down() already defines what should
happen; the driver simply was not doing it. 

Thanks again for the review.
Zaiyu Wang