Re: [Qemu-devel] [PATCH v4 0/7] qom: more efficient object property handling

[Pavel Fedin <p.fedin@samsung.com>]

 Hello!

> This series introduces a concept of object property iterators
> to QOM so callers are insulated from the specific data structures
> used for storing properties against objects/classes. It then
> converts Object to use a GHashTable for storing properties.
> Finally it introduces ObjectClass properties.

 Tested-by: Pavel Fedin <p.fedin@samsung.com>
 
> Probably the only controversial thing is the item Pavel points
> out about object_child_foreach iterators now being forbidden
> from modifying the object composition tree.

 As i already wrote, current code does not modify the tree. If necessary, it is possible to work around (e. g. make a decision about modification, stop iteration, then do the modification). I think this would pop up anyway if we change list to anything else. IMHO it's better just to acknowledge that we should not modify our tree inside iterator.

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia