From: "Jack Wang" <jack_wang@usish.com>
To: "'James E.J. Bottomley'" <JBottomley@parallels.com>
Cc: linux-scsi@vger.kernel.org, 'lindar_liu' <lindar_liu@usish.com>,
xjtuwjp@gmail.com
Subject: [PATCH] libsas: use right function to alloc smp response
Date: Wed, 6 Mar 2013 10:43:03 +0800 [thread overview]
Message-ID: <00bf01ce1a14$54f3b950$fedb2bf0$@com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]
In fact the disc_resp buffer will be overwrite by smp response, so we never
found this typo, correct it by using the right one.
>From 43c522be7a5b4ce89de725926a1fbabd70674c64 Mon Sep 17 00:00:00 2001
From: John Gong <john_gong@usish.com>
Date: Fri, 1 Mar 2013 04:08:18 -0500
Subject: [PATCH] use right function to alloc smp reponse
Signed-off-by: John Gong <john_gong@usish.com>
Signed-off-by: Jack Wang <jack_wang@usish.com>
---
drivers/scsi/libsas/sas_expander.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libsas/sas_expander.c
b/drivers/scsi/libsas/sas_expander.c
index efc6e72..e071e08 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -388,7 +388,7 @@ int sas_ex_phy_discover(struct domain_device *dev, int
single)
if (!disc_req)
return -ENOMEM;
- disc_resp = alloc_smp_req(DISCOVER_RESP_SIZE);
+ disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE);
if (!disc_resp) {
kfree(disc_req);
return -ENOMEM;
--
1.7.1
[-- Attachment #2: 0001-use-right-function-to-alloc-smp-reponse.patch --]
[-- Type: application/octet-stream, Size: 914 bytes --]
>From 43c522be7a5b4ce89de725926a1fbabd70674c64 Mon Sep 17 00:00:00 2001
From: John Gong <john_gong@usish.com>
Date: Fri, 1 Mar 2013 04:08:18 -0500
Subject: [PATCH] use right function to alloc smp reponse
Signed-off-by: John Gong <john_gong@usish.com>
Signed-off-by: Jack Wang <jack_wang@usish.com>
---
drivers/scsi/libsas/sas_expander.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/libsas/sas_expander.c b/drivers/scsi/libsas/sas_expander.c
index efc6e72..e071e08 100644
--- a/drivers/scsi/libsas/sas_expander.c
+++ b/drivers/scsi/libsas/sas_expander.c
@@ -388,7 +388,7 @@ int sas_ex_phy_discover(struct domain_device *dev, int single)
if (!disc_req)
return -ENOMEM;
- disc_resp = alloc_smp_req(DISCOVER_RESP_SIZE);
+ disc_resp = alloc_smp_resp(DISCOVER_RESP_SIZE);
if (!disc_resp) {
kfree(disc_req);
return -ENOMEM;
--
1.7.1
reply other threads:[~2013-03-06 2:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00bf01ce1a14$54f3b950$fedb2bf0$@com' \
--to=jack_wang@usish.com \
--cc=JBottomley@parallels.com \
--cc=lindar_liu@usish.com \
--cc=linux-scsi@vger.kernel.org \
--cc=xjtuwjp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.