From: "Julian C. Dunn" <jdunn@aquezada.com>
To: <netdev@vger.kernel.org>
Subject: typo in ping.c?
Date: Wed, 5 Jan 2011 22:36:27 -0500 [thread overview]
Message-ID: <00c001cbad52$e62ea050$b28be0f0$@aquezada.com> (raw)
In-Reply-To:
I sent this about a month ago to Yoshifuji Hideaki but didn't hear anything.
Perhaps it could use a wider distribution.
- Julian
-----Original Message-----
From: Julian C. Dunn [mailto:jdunn@aquezada.com]
Sent: Sunday, December 12, 2010 8:49 PM
To: 'YOSHIFUJI Hideaki'
Subject: typo in ping.c?
Hi,
I'm not an expert in C code or in iputils but I think I found a
typographical error in this commit:
http://www.linux-ipv6.org/gitweb/gitweb.cgi?p=gitroot/iputils.git;a=commitdi
ff;h=d5e3dcb81ff3828fa40eb4e8c562ca7015d7ac6a
The previous version printed the icmp_seq inline within ping_common.c, but
in your diff you are now invoking a function void pr_echo_reply().
Unfortunately, it looks like "icmp_seq" is spelled wrong: you have it
spelled as "icmp_req".
I discovered this when trying to use a tool that depended on the spelling of
"icmp_seq" and it failed.
- Julian
reply other threads:[~2011-01-06 3:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00c001cbad52$e62ea050$b28be0f0$@aquezada.com' \
--to=jdunn@aquezada.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.