From: Pavel Fedin <p.fedin@samsung.com>
To: 'Ashok Kumar' <ashoks@broadcom.com>, qemu-devel@nongnu.org
Cc: 'Shlomo Pongratz' <shlomo.pongratz@huawei.com>
Subject: Re: [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3 support for kvm mode
Date: Fri, 15 May 2015 09:42:40 +0300 [thread overview]
Message-ID: <00c401d08eda$57394490$05abcdb0$@samsung.com> (raw)
In-Reply-To: <1431624430-3996-1-git-send-email-ashoks@broadcom.com>
Hello!
> Added -M virt,gicversion=2,3 property to configure GICv2 or GICv3.
> GICv3 save/restore is not supported as vgic-v3-emul.c is yet to support
> them.
>
> Signed-off-by: Ashok Kumar <ashoks@broadcom.com>
I also work on this, just not published yet. Some notes about your version:
1. May be there should be hw/intc/arm_gicv3_kvm.c file created for GICv3? As far as i can
see, save/restore code should differ a lot.
2. kvm_arch_irqchip_create() should probe only for type we want to get. It has to be
passed there somehow from the virt machine initializer. And, if we want GICv3, then upon
failure it should return error, not zero. This is because when kvm_arch_irqchip_create()
returns zero, a fallback code is used, which will create GICv2.
3. Perhaps you should base your work on these patch sets:
https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg00941.html
https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg01505.html
I added Shlomo to cc because he might also be interested.
Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia
next prev parent reply other threads:[~2015-05-15 6:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 17:27 [Qemu-devel] [RFC PATCH] hw/arm/virt: Added preliminary GICv3 support for kvm mode Ashok Kumar
2015-05-15 6:42 ` Pavel Fedin [this message]
2015-05-19 12:50 ` Eric Auger
2015-05-21 6:47 ` Pavel Fedin
2015-05-21 8:59 ` Eric Auger
2015-05-21 14:10 ` Pavel Fedin
2015-05-21 14:24 ` Eric Auger
2015-05-19 16:45 ` Eric Auger
2015-05-18 15:44 ` Eric Auger
2015-05-19 12:52 ` Eric Auger
-- strict thread matches above, loose matches on Subject: below --
2015-05-14 20:13 Ashok Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='00c401d08eda$57394490$05abcdb0$@samsung.com' \
--to=p.fedin@samsung.com \
--cc=ashoks@broadcom.com \
--cc=qemu-devel@nongnu.org \
--cc=shlomo.pongratz@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.